Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235417

Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS

Show all headers | View raw

On Tue, Sep 29, 2015 at 10:01:36PM +0530, Naveen N. Rao wrote:
> On 2015/09/29 12:47PM, Jiri Olsa wrote:
> > On Tue, Sep 29, 2015 at 01:30:10PM +0530, Naveen N. Rao wrote:
> > 
> > SNIP
> > 
> > > > > Suka has also posted a fix for this with a different approach [1]. Can 
> > > > > you please ack/pull one of these versions? Building perf is broken on 
> > > > > v4.3-rc due to this.
> > > > 
> > > > I did not get any answer for additional comments I made to the patch
> > > > (couldnt get marc.info working, sending the patch again)
> > > 
> > > Hi Jiri,
> > > I concur with the changes you proposed to my patch here (getting rid of 
> > > the weak variant):
> > > http://article.gmane.org/gmane.linux.kernel/2046108
> > > 
> > > I am aware of the other approach you posted (and the one attached 
> > > below). When I said "please ack/pull one of these versions", I meant one 
> > > of: your version, Suka's and mine.
> > 
> > I was hoping somebody could test it on ppc ;-)
> > 
> > I think the last version (in my last email) that keeps the weak
> > variable is correct, let's wait for Arnaldo to sort this out
> 
> I just tried it, but it fails. As Suka points out in his patch:
> "Adding perf_regs.o to util/Build unconditionally, exposes a 
> redefinition error for 'perf_reg_value()' function (due to the static 
> inline version in util/perf_regs.h). So use #ifdef 
> HAVE_PERF_REGS_SUPPORT' around that function."

could you (or Suka) please reply in here with the patch?

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-09-24 14:20 +0200
  Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-24 15:00 +0200
    Re: [PATCH] perf record: Limit --intr-regs to platforms supporting PERF_REGS Stephane Eranian <eranian@google.com> - 2015-09-24 17:40 +0200
      Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-24 18:10 +0200
      Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-09-24 19:40 +0200
        Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-09-29 07:40 +0200
          Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-29 09:00 +0200
            Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-09-29 10:10 +0200
              Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-29 12:50 +0200
                Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-09-29 18:40 +0200
                Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-29 19:20 +0200
                Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com> - 2015-09-29 22:10 +0200
                Re: [PATCH] perf record: Limit --intr-regs to platforms supporting  PERF_REGS Jiri Olsa <jolsa@redhat.com> - 2015-09-29 22:40 +0200

csiph-web