Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1235053

Re: [RFC][PATCH 11/11] sched: More notrace

Show all headers | View raw

On Tue, 29 Sep 2015, Peter Zijlstra wrote:

> preempt_schedule_common() is marked notrace, but it does not use
> _notrace() preempt_count functions and __schedule() is also not marked
> notrace, which means that its perfectly possible to end up in the
> tracer from preempt_schedule_common().
> 
> So either we need more notrace, or we need to remove notrace from
> preempt_schedule_common().

More notrace is the right thing to do. We have enough pointless
information in tracing already.

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 11/11] sched: More notrace Peter Zijlstra <peterz@infradead.org> - 2015-09-29 11:50 +0200
  Re: [RFC][PATCH 11/11] sched: More notrace Thomas Gleixner <tglx@linutronix.de> - 2015-09-29 15:30 +0200
  Re: [RFC][PATCH 11/11] sched: More notrace Steven Rostedt <rostedt@goodmis.org> - 2015-09-29 18:00 +0200

csiph-web