[RFC][PATCH 11/11] sched: More notrace

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	[RFC][PATCH 11/11] sched: More notrace
Date	2015-09-29 11:50 +0200
Message-ID	<qdZHQ-2IS-11@gated-at.bofh.it> (permalink)
References	<qdZHQ-2IS-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

preempt_schedule_common() is marked notrace, but it does not use
_notrace() preempt_count functions and __schedule() is also not marked
notrace, which means that its perfectly possible to end up in the
tracer from preempt_schedule_common().

So either we need more notrace, or we need to remove notrace from
preempt_schedule_common().

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 kernel/sched/core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3044,7 +3044,7 @@ pick_next_task(struct rq *rq, struct tas
  *
  * WARNING: must be called with preemption disabled!
  */
-static void __sched __schedule(bool preempt)
+static void __sched notrace __schedule(bool preempt)
 {
 	struct task_struct *prev, *next;
 	unsigned long *switch_count;
@@ -3190,9 +3190,9 @@ void __sched schedule_preempt_disabled(v
 static void __sched notrace preempt_schedule_common(void)
 {
 	do {
-		preempt_disable();
+		preempt_disable_notrace();
 		__schedule(true);
-		sched_preempt_enable_no_resched();
+		preempt_enable_no_resched_notrace();
 
 		/*
 		 * Check again in case we missed a preemption opportunity


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH 11/11] sched: More notrace Peter Zijlstra <peterz@infradead.org> - 2015-09-29 11:50 +0200
  Re: [RFC][PATCH 11/11] sched: More notrace Thomas Gleixner <tglx@linutronix.de> - 2015-09-29 15:30 +0200
  Re: [RFC][PATCH 11/11] sched: More notrace Steven Rostedt <rostedt@goodmis.org> - 2015-09-29 18:00 +0200

csiph-web