Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234631

Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code

Show all headers | View raw

On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote:
> Remove the disabled code, for now, with #if 0.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hi,
> 
> The code after the return is dead code. There is a comment saying it is
> disabled for now, it would be good if the code is removed with #if 0 as
> well.

The compiler doesn't add it anyway, so this is the same as what you just
did, so I don't think it's needed.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: ni_tiocmd: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-28 23:00 +0200
  [PATCH] staging: comedi: cb_pcidas64: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-28 23:20 +0200
    Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:50 +0200
      Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-29 12:00 +0200
  [PATCH] staging: rtl8712: remove dead code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-29 00:00 +0200
    Re: [PATCH] staging: rtl8712: remove dead code Joshua Clayton <stillcompiling@gmail.com> - 2015-09-30 07:40 +0200
  Re: [PATCH] staging: comedi: ni_tiocmd: remove unused code Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:50 +0200

csiph-web