Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234481

[PATCH] staging: comedi: cb_pcidas64: remove unused code

Show all headers | View raw

Remove the disabled code, for now, with #if 0.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---

Hi,

The code after the return is dead code. There is a comment saying it is
disabled for now, it would be good if the code is removed with #if 0 as
well.

Thanks,
Luis

 drivers/staging/comedi/drivers/cb_pcidas64.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index d33b8fe..f86ea9f 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -2233,10 +2233,12 @@ static int use_hw_sample_counter(struct comedi_cmd *cmd)
 /* disable for now until I work out a race */
 	return 0;
 
+#if 0
 	if (cmd->stop_src == TRIG_COUNT && cmd->stop_arg <= max_counter_value)
 		return 1;
 
 	return 0;
+#endif
 }
 
 static void setup_sample_counters(struct comedi_device *dev,
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: comedi: ni_tiocmd: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-28 23:00 +0200
  [PATCH] staging: comedi: cb_pcidas64: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-28 23:20 +0200
    Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:50 +0200
      Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-29 12:00 +0200
  [PATCH] staging: rtl8712: remove dead code Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-09-29 00:00 +0200
    Re: [PATCH] staging: rtl8712: remove dead code Joshua Clayton <stillcompiling@gmail.com> - 2015-09-30 07:40 +0200
  Re: [PATCH] staging: comedi: ni_tiocmd: remove unused code Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:50 +0200

csiph-web