Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1234629

Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

Path csiph.com!eternal-september.org!feeder.eternal-september.org!news.mixmin.net!weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists
Date Tue, 29 Sep 2015 03:30:02 +0200
Message-ID <qdRTY-8pF-9@gated-at.bofh.it> (permalink)
References <qdLbP-7cd-3@gated-at.bofh.it>
X-Original-To Chandra S Gorentla <csgorentla@gmail.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.24 (2015-08-30)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 23
Organization linux.* mail to news gateway
X-Original-Cc dan.carpenter@oracle.com, johnny.kim@atmel.com, rachel.kim@atmel.com, dean.lee@atmel.com, chris.park@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com
X-Original-Date Tue, 29 Sep 2015 02:44:02 +0200
X-Original-Message-ID <20150929004402.GB7811@kroah.com>
X-Original-References <1443464037-3591-1-git-send-email-csgorentla@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1234629

Show key headers only | View raw


On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
>  - The message queue is replaced with standard Linux linked list
>  - kmem_cache is used for list members

Why?

>  - A check for return value of receive method is added
>  - GFP_ATOMIC is changed to GFP_KERNEL

Why?  Are you sure that is safe?

>  - A few other related minor changes

Be specific please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists Chandra S Gorentla <csgorentla@gmail.com> - 2015-09-28 20:20 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:30 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Chandra Gorentla <csgorentla@gmail.com> - 2015-09-30 14:40 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-29 04:40 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Chandra Gorentla <csgorentla@gmail.com> - 2015-09-30 14:50 +0200
      Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-30 15:30 +0200

csiph-web