Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists
Date	2015-09-29 04:40 +0200
Message-ID	<qdSZH-1Aj-5@gated-at.bofh.it> (permalink)
References	<qdLbP-7cd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Sep 28, 2015 at 11:43:55PM +0530, Chandra S Gorentla wrote:
>  - The message queue is replaced with standard Linux linked list
>  - kmem_cache is used for list members
>  - A check for return value of receive method is added
>  - GFP_ATOMIC is changed to GFP_KERNEL
>  - A few other related minor changes

These should be listed and explained.

>  
>  	while (1) {
> -		wilc_mq_recv(&gMsgQHostIF, &msg, sizeof(struct host_if_msg), &u32Ret);
> +		ret = wilc_mq_recv(&gMsgQHostIF, &msg,
> +					sizeof(struct host_if_msg), &u32Ret);
> +		if (ret)
> +			continue;
> +

I asked before if this was a forever loop and never got a response.
Also what does this have to do with list macros?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] drivers: staging: wilc1000: Replace message queue with standard Linux lists Chandra S Gorentla <csgorentla@gmail.com> - 2015-09-28 20:20 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Greg KH <gregkh@linuxfoundation.org> - 2015-09-29 03:30 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Chandra Gorentla <csgorentla@gmail.com> - 2015-09-30 14:40 +0200
  Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-29 04:40 +0200
    Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Chandra Gorentla <csgorentla@gmail.com> - 2015-09-30 14:50 +0200
      Re: [PATCH 1/2] drivers: staging: wilc1000: Replace message queue  with standard Linux lists Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-30 15:30 +0200

csiph-web