Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64

From	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date	2015-09-28 10:50 +0200
Message-ID	<qdCie-Fm-1@gated-at.bofh.it> (permalink)
References	<qdzkm-4Rn-11@gated-at.bofh.it> <qdzkm-4Rn-13@gated-at.bofh.it> <qdBm9-7It-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2015/9/28 15:40, Ard Biesheuvel wrote:
> On 28 September 2015 at 06:34, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> Now, ARM64 is also support EFI startup. We hope use EFI runtime services
>> to get/set current time and date.
>>
>> RTC_LIB only controls some configs in drivers/char/Kconfig(included
>> EFI_RTC), and will be automatically selected when RTC_CLASS opened. So
>> this patch have no functional change but give an opportunity to select
>> EFI_RTC when RTC_CLASS closed.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm64/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 07d1811..25cec57 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -85,7 +85,7 @@ config ARM64
>>         select PERF_USE_VMALLOC
>>         select POWER_RESET
>>         select POWER_SUPPLY
>> -       select RTC_LIB
>> +       select RTC_LIB if !EFI
>>         select SPARSE_IRQ
>>         select SYSCTL_EXCEPTION_TRACE
>>         select HAVE_CONTEXT_TRACKING
> 
> You can currently enable EFI_RTC just fine on arm64 when EFI is enabled.
> Why exactly do you need this patch on top?

Because when we run "make ARCH=arm64 menuconfig", RTC_LIB is always selected. And we have no opportunity
to deselect it. And EFI_RTC can be displayed only when RTC_LIB=n.

--------drivers/rtc/Kconfig-------
config RTC_LIB
        bool

menuconfig RTC_CLASS
        bool "Real Time Clock"
        default n
        depends on !S390 && !UML
        select RTC_LIB

--------------drivers/char/Kconfig--------------
if RTC_LIB=n

......

config EFI_RTC
        bool "EFI Real Time Clock Services"
        depends on IA64 || ARM64

.......

endif # RTC_LIB

> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Zhen Lei <thunder.leizhen@huawei.com> - 2015-09-28 07:40 +0200
  Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 09:40 +0200
    Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 10:40 +0200
      Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 10:50 +0200
        Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 11:50 +0200
          Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 12:00 +0200
  Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-09-28 09:50 +0200
    Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 10:50 +0200

csiph-web