Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1233916

Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64

From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date 2015-09-28 09:40 +0200
Message-ID <qdBcu-7x9-11@gated-at.bofh.it> (permalink)
References <qdzkm-4Rn-11@gated-at.bofh.it> <qdzkm-4Rn-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Monday 28 September 2015 13:34:38 Zhen Lei wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 07d1811..25cec57 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -85,7 +85,7 @@ config ARM64
>         select PERF_USE_VMALLOC
>         select POWER_RESET
>         select POWER_SUPPLY
> -       select RTC_LIB
> +       select RTC_LIB if !EFI
>         select SPARSE_IRQ
>         select SYSCTL_EXCEPTION_TRACE
>         select HAVE_CONTEXT_TRACKING

Sorry, we can't do that: enabling EFI has to be done in a way that it only
adds features but not disables them.

Your patch breaks RTC on all non-EFI platforms as soon as CONFIG_EFI
is selected by the user.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Zhen Lei <thunder.leizhen@huawei.com> - 2015-09-28 07:40 +0200
  Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 09:40 +0200
    Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 10:40 +0200
      Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 10:50 +0200
        Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 11:50 +0200
          Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Arnd Bergmann <arnd@arndb.de> - 2015-09-28 12:00 +0200
  Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-09-28 09:50 +0200
    Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64 "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2015-09-28 10:50 +0200

csiph-web