Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events
Date	2015-09-25 10:30 +0200
Message-ID	<qcwye-4jx-13@gated-at.bofh.it> (permalink)
References	<qcrRU-6eR-5@gated-at.bofh.it> <qcrRU-6eR-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 25, 2015 at 03:21:19AM +0000, He Kuang wrote:

SNIP

> diff --git a/tools/perf/util/parse-events.h b/tools/perf/util/parse-events.h
> index c7b904a..f13d3cc 100644
> --- a/tools/perf/util/parse-events.h
> +++ b/tools/perf/util/parse-events.h
> @@ -119,7 +119,8 @@ int parse_events__modifier_group(struct list_head *list, char *event_mod);
>  int parse_events_name(struct list_head *list, char *name);
>  int parse_events_add_tracepoint(struct list_head *list, int *idx,
>  				char *sys, char *event,
> -				struct parse_events_error *error);
> +				struct parse_events_error *error,
> +				struct list_head *head_config);
>  int parse_events_add_numeric(struct parse_events_evlist *data,
>  			     struct list_head *list,
>  			     u32 type, u64 config,
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 8bcc458..6b15a80 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -67,6 +67,7 @@ static inc_group_count(struct list_head *list,
>  %type <head> event_legacy_cache
>  %type <head> event_legacy_mem
>  %type <head> event_legacy_tracepoint
> +%type <str_group> __event_legacy_tracepoint
>  %type <head> event_legacy_numeric
>  %type <head> event_legacy_raw
>  %type <head> event_def
> @@ -84,6 +85,10 @@ static inc_group_count(struct list_head *list,
>  	u64 num;
>  	struct list_head *head;
>  	struct parse_events_term *term;
> +	struct str_group{
> +		char *name1;
> +		char *name2;
> +	} str_group;


perhaps tracepoint_name would be more suitable?
with 'struct tracepoint_name' instead of str_group

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] perf tools: Prompt error message for wrong terms of hw/sw events He Kuang <hekuang@huawei.com> - 2015-09-25 05:30 +0200
  [PATCH 2/2] perf tools: Enable event_config terms to tracepoint events He Kuang <hekuang@huawei.com> - 2015-09-25 05:30 +0200
    Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint  events Jiri Olsa <jolsa@redhat.com> - 2015-09-25 10:30 +0200
    Re: [PATCH 2/2] perf tools: Enable event_config terms to tracepoint  events Jiri Olsa <jolsa@redhat.com> - 2015-09-25 10:40 +0200
  Re: [PATCH 1/2] perf tools: Prompt error message for wrong terms of  hw/sw events Jiri Olsa <jolsa@redhat.com> - 2015-09-25 10:20 +0200

csiph-web