Groups > linux.kernel > #1232035

Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
Date	Thu, 24 Sep 2015 12:30:02 +0200
Message-ID	<qcbWO-eL-19@gated-at.bofh.it> (permalink)
References	<qbYPT-6uy-3@gated-at.bofh.it> <qcaHo-6Yx-15@gated-at.bofh.it>
X-Original-To	Dan Carpenter <dan.carpenter@oracle.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pOQ0y2cYS4h5vJxBSHEWJiITSzGI2jM3vNXEgFVw99M=; b=SNzS3XH8+NHitFMfhGEPIZPwZNLcn0hKpIdZXY3fmcKDxKP3JJg87vL+Ei7FeCsF9T ah050B4Diu8MIpnadc3lp5AUxYDxwTyDcWfjerwQvCNpK40OoQi/I73h+5zinEq+ggPN crlt7hvuMcjDSk9/DIp3IAGimufxNbh1ZocuxcoJv4HgieU4cAC/nLBLsqVYGh9+ayJy iooPFXQYBAJ0DjMCUtKDzKnv+7jkdU6Kni9TwgsIA4I1VC/xta8QhHe4gnqJeJnaKEfv v5uW6V7eZTQ8NA/WTW+R5DEqKp7E2xIHp1lyp/yRS0c3kLUZYv3AtAJIX+Cbij9BTeOK AI2A==
X-Received	by 10.69.26.38 with SMTP id iv6mr43670175pbd.151.1443090448367; Thu, 24 Sep 2015 03:27:28 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Punit Vara <punitvara@gmail.com>, devel@driverdev.osuosl.org, florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net
X-Original-Date	Thu, 24 Sep 2015 15:57:22 +0530
X-Original-Message-ID	<20150924102722.GB11025@sudip-pc>
X-Original-References	<1443039862-6197-1-git-send-email-punitvara@gmail.com> <20150924090001.GK4953@mwanda>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1232035

Show key headers only | View raw

On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
> On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
> > This is a patch to the rtl871x_mp.h that fixes up following warnings
> > reported by checkpatch.pl :
> > 
> > -Block comments use a trailing */ on a separate line
> > 
> > Signed-off-by: Punit Vara <punitvara@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
> > index 75893f2..20a4273 100644
> > --- a/drivers/staging/rtl8712/rtl871x_mp.h
> > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
> > @@ -108,7 +108,8 @@ struct mp_priv {
> >  	unsigned char network_macaddr[6];
> >  	/*Testing Flag*/
> >  	u32 mode;/*0 for normal type packet,
> 
> This first line is missing some spaces so the whole comment needs to be
> redone.
> 
> 	u32 mode; /* 0 for normal type packet,
> 		   * 1 for loopback packet (16bytes TXCMD)
> 		   */
If he is modifying the first line then shouldn't it be:
	u32 mode; /* 
		   * 0 for normal type packet,
		   * 1 for loopback packet (16bytes TXCMD)
		   */

regards
sudip	
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Punit Vara <punitvara@gmail.com> - 2015-09-23 22:30 +0200
  Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 11:10 +0200
    Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-24 12:30 +0200
      Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 13:30 +0200
        Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix  for block comment punit vara <punitvara@gmail.com> - 2015-09-24 19:00 +0200

csiph-web