Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

From	punit vara <punitvara@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment
Date	2015-09-24 19:00 +0200
Message-ID	<qci2d-rV-11@gated-at.bofh.it> (permalink)
References	<qbYPT-6uy-3@gated-at.bofh.it> <qcaHo-6Yx-15@gated-at.bofh.it> <qcbWO-eL-19@gated-at.bofh.it> <qccSS-1zC-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 24, 2015 at 4:52 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote:
>> On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
>> > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
>> > > This is a patch to the rtl871x_mp.h that fixes up following warnings
>> > > reported by checkpatch.pl :
>> > >
>> > > -Block comments use a trailing */ on a separate line
>> > >
>> > > Signed-off-by: Punit Vara <punitvara@gmail.com>
>> > > ---
>> > >  drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
>> > >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > index 75893f2..20a4273 100644
>> > > --- a/drivers/staging/rtl8712/rtl871x_mp.h
>> > > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > @@ -108,7 +108,8 @@ struct mp_priv {
>> > >   unsigned char network_macaddr[6];
>> > >   /*Testing Flag*/
>> > >   u32 mode;/*0 for normal type packet,
>> >
>> > This first line is missing some spaces so the whole comment needs to be
>> > redone.
>> >
>> >     u32 mode; /* 0 for normal type packet,
>> >                * 1 for loopback packet (16bytes TXCMD)
>> >                */
>> If he is modifying the first line then shouldn't it be:
>>       u32 mode; /*
>>                  * 0 for normal type packet,
>>                  * 1 for loopback packet (16bytes TXCMD)
>>                  */
>>
>
> Networking code doesn't use the empty first line.
>
> regards,
> dan carpenter
>



Yes I did that mistake in 2-3 files but after that I have got I was
doing mistake . Then I did not repeat the mistake. I Am waiting for
Greg's response whether again I have to send all patches in series So
I will definitely resend after fixing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment Punit Vara <punitvara@gmail.com> - 2015-09-23 22:30 +0200
  Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 11:10 +0200
    Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-24 12:30 +0200
      Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings  fix for block comment Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-24 13:30 +0200
        Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix  for block comment punit vara <punitvara@gmail.com> - 2015-09-24 19:00 +0200

csiph-web