Re: [PATCH v4 1/2] pinctrl: Add driver for Alphascale asm9260 pinctrl

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] pinctrl: Add driver for Alphascale asm9260 pinctrl
Date	2015-09-25 19:20 +0200
Message-ID	<qcEP7-7Rs-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <pcbcB-3AR-7@gated-at.bofh.it> <pmOFK-14i-43@gated-at.bofh.it> <pplea-5An-9@gated-at.bofh.it> <ppCI1-6mX-5@gated-at.bofh.it> <q6GAh-2qZ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 8, 2015 at 10:55 PM, Oleksij Rempel <linux@rempel-privat.de> wrote:
> [Me]
>> Why is it necessary for the driver to copy one description of
>> the pin into another?
>
> If i understand it correctly, pinctrl_pin_desc is essential part of
> pinmux framework. Theoretically i should define just statical array of
> this struct, but by this number of pins and functions it hard to keep it
> readable and error free. So i decided to create asm9260_mux_table which
> contains every thing i need. The side effect is higher memory usage
> since i need to create pinctrl_pin_desc on fly.
>
> May be i miss some thing?

I don't see how having code copying data from one data container
to another makes things "more readable and error free". Go for *one*
static definition. Also the memory waste is a total no-no.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/2] pinctrl: Add driver for Alphascale asm9260 pinctrl Linus Walleij <linus.walleij@linaro.org> - 2015-09-25 19:20 +0200

csiph-web