Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 5/6] virtio-gpu: add basic prime support
Date	2015-09-22 18:20 +0200
Message-ID	<qbysr-219-47@gated-at.bofh.it> (permalink)
References	<qb5Tr-2Se-3@gated-at.bofh.it> <qb5Tr-2Se-17@gated-at.bofh.it> <qbsdl-1pF-39@gated-at.bofh.it> <qbxG2-P2-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Sep 22, 2015 at 05:24:29PM +0200, Gerd Hoffmann wrote:
> > > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > > +		       struct vm_area_struct *area)
> > > +{
> > > +	WARN_ONCE(1, "not implemented");
> > > +	return ENOSYS;
> > 
> > This can get called by userspace, so please don't WARN here. Also missing
> > negate sign:
> > 
> > 	return -ENOSYS;
> 
> Hmm now checkpatch throws a warning at me:
> 
> <quote>
>    WARNING: ENOSYS means 'invalid syscall nr' and nothing else
>    #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
>    +       return -ENOSYS;
> </quote>
> 
> I guess I should use something else then (here and elsewhere in the
> file)?  Maybe -EINVAL?  Other suggestions?

-ENODEV is what we occasionally pick. drm is fairly creative at errno
abuse, e.g. we already use -ENOENT to signal any kind of lookup failure in
ioctls (even if the fd itself is obviously there so not possible that the
fd isn't there).

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann <kraxel@redhat.com> - 2015-09-21 11:50 +0200
  Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Daniel Vetter <daniel@ffwll.ch> - 2015-09-22 11:40 +0200
    Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann <kraxel@redhat.com> - 2015-09-22 17:30 +0200
      Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Daniel Vetter <daniel@ffwll.ch> - 2015-09-22 18:20 +0200

csiph-web