Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230327

Re: [PATCH v2 5/6] virtio-gpu: add basic prime support

Show all headers | View raw

> > +int virtgpu_gem_prime_mmap(struct drm_gem_object *obj,
> > +		       struct vm_area_struct *area)
> > +{
> > +	WARN_ONCE(1, "not implemented");
> > +	return ENOSYS;
> 
> This can get called by userspace, so please don't WARN here. Also missing
> negate sign:
> 
> 	return -ENOSYS;

Hmm now checkpatch throws a warning at me:

<quote>
   WARNING: ENOSYS means 'invalid syscall nr' and nothing else
   #12: FILE: drivers/gpu/drm/virtio/virtgpu_prime.c:70:
   +       return -ENOSYS;
</quote>

I guess I should use something else then (here and elsewhere in the
file)?  Maybe -EINVAL?  Other suggestions?

thanks,
  Gerd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann <kraxel@redhat.com> - 2015-09-21 11:50 +0200
  Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Daniel Vetter <daniel@ffwll.ch> - 2015-09-22 11:40 +0200
    Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Gerd Hoffmann <kraxel@redhat.com> - 2015-09-22 17:30 +0200
      Re: [PATCH v2 5/6] virtio-gpu: add basic prime support Daniel Vetter <daniel@ffwll.ch> - 2015-09-22 18:20 +0200

csiph-web