Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230207

Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction which takes u64

Show all headers | View raw

On Tue, Sep 22, 2015 at 03:09:33PM +0200, David Sterba wrote:
> On Sun, Sep 13, 2015 at 06:47:20PM +0000, Alexandru Moise wrote:
> > Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
> > ---
> > v2: Forgot to add transaction.h when I made the commit, many thanks
> > Holger for pointing it out.
> > 
> >  fs/btrfs/transaction.c | 2 +-
> >  fs/btrfs/transaction.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> > index 8f259b3..8a83acd 100644
> > --- a/fs/btrfs/transaction.c
> > +++ b/fs/btrfs/transaction.c
> > @@ -570,7 +570,7 @@ reserve_fail:
> >  }
> >  
> >  struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
> > -						   int num_items)
> > +						   u64 num_items)
> 
> I think it's better to do it the other way around, ie. let all the
> equivalents of 'num_items' be an int. We know that this is a small
> number, using u64 for that is an overkill. As the number is always
> positive, please make it 'unsigned'.

So you'd want it to be "unsigned int" or "u32"?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] btrfs: avoid passing int param to start_transaction  which takes u64 Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-13 17:50 +0200
  Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction  which takes u64 David Sterba <dsterba@suse.cz> - 2015-09-22 15:20 +0200
    Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction  which takes u64 Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-22 15:40 +0200
      Re: [PATCH 1/2] btrfs: avoid passing int param to start_transaction  which takes u64 David Sterba <dsterba@suse.cz> - 2015-09-22 15:50 +0200

csiph-web