Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Pravin Shelar <pshelar@nicira.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr
Date	Mon, 21 Sep 2015 19:50:02 +0200
Message-ID	<qbdnY-5do-9@gated-at.bofh.it> (permalink)
References	<qb9u2-83M-3@gated-at.bofh.it> <qb9Nq-8s4-57@gated-at.bofh.it>
X-Original-To	Andrzej Hajda <a.hajda@samsung.com>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uYATb5gQz/wem6Wpi0n3iz9dUAUjLAgyI0jVtKsXPJQ=; b=PeVTNMEfWpLQJ9O02ltEBBG1an8aS/sS/DpFHge1nyw9UPwjd1JIt+aj+nF8qdagKO 2SIP1rKngYRs8FKVYMnpQJz/UmrZRdKmm1sfUAJX0JfDoUEKpqEEsR6v2mNflWJqPAAB V05TRVSAIuvkUI4kh+K9NhEFUokc4e5KIwJDHC6B1xgkFc1hpWzxFWM9l4uq+2b1Oy8R 54drzbUQfdvAtXlQ0epAPWL3DlDiCBK0ha1HcpwSAoYGSRQ8u6U3mbSNywT+mb9rlwn/ QGwB5GkttnOnw96Qm98n2pP7OimWlAnkn1fSyJt2rCHJnqquq0jNDd9ptVMGReJc3CZI 0xPA==
X-Gm-Message-State	ALoCoQnAecSnNIOzHSWJZGBFp0LTYdvtVHUoT7rrCPqOe0sTYazC7dHhHOKXnU7LW7HeQM1Dl42z
MIME-Version	1.0
X-Received	by 10.107.135.169 with SMTP id r41mr32294500ioi.152.1442857557896; Mon, 21 Sep 2015 10:45:57 -0700 (PDT)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	LKML <linux-kernel@vger.kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Marek Szyprowski <m.szyprowski@samsung.com>, "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>, "dev@openvswitch.org" <dev@openvswitch.org>
X-Original-Date	Mon, 21 Sep 2015 10:45:57 -0700
X-Original-Message-ID	<CALnjE+qFk_1xKjDHohT8PnjS0WDbC2WEZLb40DvJa2rzXye60Q@mail.gmail.com>
X-Original-References	<1442842450-29769-1-git-send-email-a.hajda@samsung.com> <1442842450-29769-9-git-send-email-a.hajda@samsung.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1229601

Show key headers only | View raw

On Mon, Sep 21, 2015 at 6:33 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  net/openvswitch/conntrack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index 002a755..fde3391 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
> @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto)
>         const struct nf_conntrack_helper *helper;
>         const struct nf_conn_help *help;
>         enum ip_conntrack_info ctinfo;
> -       unsigned int protoff;
> +       int protoff;
>         struct nf_conn *ct;
>

A patch is already pushed to the net tree to fix this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 16:00 +0200
  Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr Pravin Shelar <pshelar@nicira.com> - 2015-09-21 19:50 +0200

csiph-web