Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229601

Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr

Show all headers | View raw

On Mon, Sep 21, 2015 at 6:33 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
>  net/openvswitch/conntrack.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index 002a755..fde3391 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
> @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto)
>         const struct nf_conntrack_helper *helper;
>         const struct nf_conn_help *help;
>         enum ip_conntrack_info ctinfo;
> -       unsigned int protoff;
> +       int protoff;
>         struct nf_conn *ct;
>

A patch is already pushed to the net tree to fix this issue.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr Andrzej Hajda <a.hajda@samsung.com> - 2015-09-21 16:00 +0200
  Re: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr Pravin Shelar <pshelar@nicira.com> - 2015-09-21 19:50 +0200

csiph-web