Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231402

Re: [PATCH] hid-core: Avoid uninitialized buffer access

Show all headers | View raw

On Fri, 18 Sep 2015, Darren Hart wrote:

> From: Richard Purdie <richard.purdie@linuxfoundation.org>
> 
> hid_connect adds various strings to the buffer but they're all
> conditional. You can find circumstances where nothing would be written
> to it but the kernel will still print the supposedly empty buffer with
> printk. This leads to corruption on the console/in the logs.
> 
> Ensure buf is initialized to an empty string.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> [dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: linux-input@vger.kernel.org
> Cc: stable@vger.kernel.org
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> ---
>  drivers/hid/hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 70a11ac..c0fbf4e 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1611,7 +1611,7 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
>  		"Multi-Axis Controller"
>  	};
>  	const char *type, *bus;
> -	char buf[64];
> +	char buf[64] = "";
>  	unsigned int i;
>  	int len;
>  	int ret;

Applied to hid.git#for-4.3/upstream-fixes.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] hid-core: Avoid uninitialized buffer access Jiri Kosina <jikos@kernel.org> - 2015-09-23 14:10 +0200

csiph-web