Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231401

[PATCH v2 2/3] usb: gadget: f_midi: free usb request when done

Show all headers | View raw

req->actual == req->length means that there is no data left to enqueue,
so free the request.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---

Changes in v2:
 * Re enqueue not fully completed requests, instead of read ALSA buffers.

 drivers/usb/gadget/function/f_midi.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index edb84ca..62356cf 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -256,10 +256,12 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req)
 			/* We received stuff. req is queued again, below */
 			f_midi_handle_out_data(ep, req);
 		} else if (ep == midi->in_ep) {
-			/* Our transmit completed. See if there's more to go.
-			 * f_midi_transmit eats req, don't queue it again. */
-			f_midi_transmit(midi, req);
-			return;
+			/* Our transmit completed. If there is no more to go,
+			   don't queue it again. */
+			if (req->actual == req->length) {
+				free_ep_req(ep, req);
+				return;
+			}
 		}
 		break;
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] usb: gadget: f_midi: free usb request when done "Felipe F. Tonello" <eu@felipetonello.com> - 2015-09-23 14:10 +0200
  Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-09-23 15:20 +0200
  Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done Clemens Ladisch <clemens@ladisch.de> - 2015-09-24 08:50 +0200
  Re: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done Felipe Tonello <eu@felipetonello.com> - 2015-09-25 11:30 +0200

csiph-web