Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Vladimir Murzin <vladimir.murzin@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver
Date	Mon, 08 Feb 2016 18:20:02 +0100
Message-ID	<qZXDI-8ih-31@gated-at.bofh.it> (permalink)
References	<qXHD3-2bY-3@gated-at.bofh.it> <qXHD3-2bY-7@gated-at.bofh.it> <qZrNv-2K8-1@gated-at.bofh.it> <qZS1k-4tX-29@gated-at.bofh.it> <qZXkp-7Uw-53@gated-at.bofh.it>
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	arnd@arndb.de, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, u.kleine-koenig@pengutronix.de, andy.shevchenko@gmail.com, mark.rutland@arm.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jslaby@suse.cz, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 08 Feb 2016 17:17:57 +0000
X-Original-Message-ID	<56B8CDC5.5010504@arm.com>
X-Original-References	<1454413199-26573-1-git-send-email-vladimir.murzin@arm.com> <1454413199-26573-5-git-send-email-vladimir.murzin@arm.com> <20160207071154.GA32017@kroah.com> <56B87928.7020803@arm.com> <20160208165226.GA11593@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1329361

Show key headers only | View raw

On 08/02/16 16:52, Greg KH wrote:
> On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote:
>> On 07/02/16 07:11, Greg KH wrote:
>>>> +
>>>> +#define SERIAL_NAME "ttyS"
>>>
>>> You can't be "ttyS", there's already a serial port named that, please
>>> use a unique name and a new major/minor number (dynamic ideally).
>>>
>>
>> Hi Greg,
>>
>> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
>> back if you prefer that, but I'd be glad to know what I've been missing?
>>
>> [1] https://lkml.org/lkml/2015/12/13/8
> 
> Yeah, I was wrong, sorry about that, my fault.
> 

I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"?

P.S.
Any chance you could look at the rest of the patch?

Cheers
Vladimir

> greg k-h
> 
> 
>

Thread

[PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-02 12:50 +0100
  Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 08:20 +0100
    Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-08 12:20 +0100
      Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-08 18:00 +0100
        Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-08 18:20 +0100
          Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-08 18:30 +0100

csiph-web