Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328937

Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

From Vladimir Murzin <vladimir.murzin@arm.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver
Date 2016-02-08 12:20 +0100
Message-ID <qZS1k-4tX-29@gated-at.bofh.it> (permalink)
References <qXHD3-2bY-3@gated-at.bofh.it> <qXHD3-2bY-7@gated-at.bofh.it> <qZrNv-2K8-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 07/02/16 07:11, Greg KH wrote:
>> +
>> +#define SERIAL_NAME "ttyS"
> 
> You can't be "ttyS", there's already a serial port named that, please
> use a unique name and a new major/minor number (dynamic ideally).
> 

Hi Greg,

I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
back if you prefer that, but I'd be glad to know what I've been missing?

[1] https://lkml.org/lkml/2015/12/13/8

Thanks
Vladimir

> thanks,
> 
> greg k-h
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-02 12:50 +0100
  Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 08:20 +0100
    Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-08 12:20 +0100
      Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-08 18:00 +0100
        Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin <vladimir.murzin@arm.com> - 2016-02-08 18:20 +0100
          Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-08 18:30 +0100

csiph-web