Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1329064
| From | Robert Richter <robert.richter@caviumnetworks.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address |
| Date | 2016-02-08 14:50 +0100 |
| Message-ID | <qZUmu-5Zc-19@gated-at.bofh.it> (permalink) |
| References | <qZSNH-50Q-3@gated-at.bofh.it> <qZSNI-50Q-29@gated-at.bofh.it> <qZUcQ-5U1-55@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08.02.16 16:30:37, Sergei Shtylyov wrote:
> >@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
> > goto out;
> >
> > if (!is_valid_ether_addr(mac)) {
> >+ dev_warn(dev, "MAC address invalid: %pM\n", mac);
>
> dev_er(), maybe?
Since the driver may continue, my choice was a warning only.
-Robert
>
> > ret = -EINVAL;
> > goto out;
> > }
> >
> >+ dev_info(dev, "MAC address set to: %pM\n", mac);
> >+
> > memcpy(dst, mac, ETH_ALEN);
> > out:
> > return ret;
> [...]
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
[PATCH 6/6] net: thunderx: Alloc higher order pages when pagesize is small sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
[PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-08 14:40 +0100
Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Robert Richter <robert.richter@caviumnetworks.com> - 2016-02-08 14:50 +0100
Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-08 15:00 +0100
Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Bjørn Mork <bjorn@mork.no> - 2016-02-08 15:00 +0100
[PATCH 3/6] net: thunderx: Assign affinity hints to vf's interrupts sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
[PATCH 2/6] net: thunderx: Use napi_schedule_irqoff() sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
csiph-web