Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328977

[PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address

Show all headers | View raw

From: Robert Richter <rrichter@cavium.com>

Signed-off-by: Robert Richter <rrichter@cavium.com>
Signed-off-by: Sunil Goutham <sgoutham@cavium.com>
---
 drivers/net/ethernet/cavium/thunder/thunder_bgx.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
index 111835b..cfee496 100644
--- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
+++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
@@ -886,7 +886,8 @@ static void bgx_get_qlm_mode(struct bgx *bgx)
 
 #ifdef CONFIG_ACPI
 
-static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
+static int acpi_get_mac_address(struct device *dev, struct acpi_device *adev,
+				u8 *dst)
 {
 	u8 mac[ETH_ALEN];
 	int ret;
@@ -897,10 +898,13 @@ static int acpi_get_mac_address(struct acpi_device *adev, u8 *dst)
 		goto out;
 
 	if (!is_valid_ether_addr(mac)) {
+		dev_warn(dev, "MAC address invalid: %pM\n", mac);
 		ret = -EINVAL;
 		goto out;
 	}
 
+	dev_info(dev, "MAC address set to: %pM\n", mac);
+
 	memcpy(dst, mac, ETH_ALEN);
 out:
 	return ret;
@@ -911,14 +915,15 @@ static acpi_status bgx_acpi_register_phy(acpi_handle handle,
 					 u32 lvl, void *context, void **rv)
 {
 	struct bgx *bgx = context;
+	struct device *dev = &bgx->pdev->dev;
 	struct acpi_device *adev;
 
 	if (acpi_bus_get_device(handle, &adev))
 		goto out;
 
-	acpi_get_mac_address(adev, bgx->lmac[bgx->lmac_count].mac);
+	acpi_get_mac_address(dev, adev, bgx->lmac[bgx->lmac_count].mac);
 
-	SET_NETDEV_DEV(&bgx->lmac[bgx->lmac_count].netdev, &bgx->pdev->dev);
+	SET_NETDEV_DEV(&bgx->lmac[bgx->lmac_count].netdev, dev);
 
 	bgx->lmac[bgx->lmac_count].lmacid = bgx->lmac_count;
 out:
-- 
1.7.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] net: thunderx: Setting IRQ affinity hints and other optimizations sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
  [PATCH 6/6] net: thunderx: Alloc higher order pages when pagesize is small sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
  [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
    Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac  address Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-08 14:40 +0100
      Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac  address Robert Richter <robert.richter@caviumnetworks.com> - 2016-02-08 14:50 +0100
      Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac  address Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-08 15:00 +0100
      Re: [PATCH 5/6] net: thunderx: bgx: Add log message when setting mac address Bjørn Mork <bjorn@mork.no> - 2016-02-08 15:00 +0100
  [PATCH 3/6] net: thunderx: Assign affinity hints to vf's interrupts sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100
  [PATCH 2/6] net: thunderx: Use napi_schedule_irqoff() sunil.kovvuri@gmail.com - 2016-02-08 13:10 +0100

csiph-web