Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs

From	"Andrew F. Davis" <afd@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs
Date	2016-02-07 17:50 +0100
Message-ID	<qZAH8-l6-15@gated-at.bofh.it> (permalink)
References	<qYXPs-6RV-23@gated-at.bofh.it> <qZiAy-4L6-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/06/2016 03:25 PM, Florian Fainelli wrote:
> Le 05/02/2016 15:13, Andrew F. Davis a écrit :
>> The TI TLK10x Ethernet PHYs are similar in the interrupt relevant
>> registers and so are compatible with the DP83848x devices already
>> supported. Add these and re-order code to support additional PHYs.
>
> This looks fine, but this could also be broken down into 3 commits:
>
> - one which adds the macro to add new PHY entries
> - one which renames DP83848_PHY_ID to DP83848C_PHY_ID
> - one which factors out the interrupt enable mask
>

No problem, will do.

>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>   drivers/net/phy/dp83848.c | 89 ++++++++++++++++++++++++++++-------------------
>>   1 file changed, 53 insertions(+), 36 deletions(-)
>>
>> diff --git a/drivers/net/phy/dp83848.c b/drivers/net/phy/dp83848.c
>> index 5e14e62..bc88259 100644
>> --- a/drivers/net/phy/dp83848.c
>> +++ b/drivers/net/phy/dp83848.c
>> @@ -1,7 +1,8 @@
>>   /*
>>    * Driver for the Texas Instruments DP83848 PHY
>>    *
>> - * Copyright (C) 2015 Texas Instruments Inc.
>> + * Copyright (C) 2015-2016 Texas Instruments Incorporated - http://www.ti.com/
>> + *	Andrew F. Davis <afd@ti.com>
>
> We have the git changelog to know who added changes to the driver, you
> can drop that specific change and just bump the copyright year.

I was the original author and forgot to add this, just like the consistency
with other drivers with named authors, but not a big deal so I can drop that.

Andrew

> --
> Florian
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet PHYs "Andrew F. Davis" <afd@ti.com> - 2016-02-06 00:20 +0100
  Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet  PHYs Florian Fainelli <f.fainelli@gmail.com> - 2016-02-06 22:30 +0100
    Re: [PATCH] net: phy: dp83848: Add support for TI TLK10x Ethernet  PHYs "Andrew F. Davis" <afd@ti.com> - 2016-02-07 17:50 +0100

csiph-web