Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1326995
| From | Timur Tabi <timur@codeaurora.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support |
| Date | 2016-02-04 17:50 +0100 |
| Message-ID | <qYvgu-4wj-13@gated-at.bofh.it> (permalink) |
| References | <qY9pF-4WX-3@gated-at.bofh.it> <qY9pF-4WX-15@gated-at.bofh.it> <qYv6O-4s9-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Mathieu Poirier wrote:
>> >+#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC
>> >+ irq = platform_get_irq(pdev, 0);
>> >+ if (irq < 0) {
>> >+ dev_err(dev, "unable to get ws0 interrupt.\n");
>> >+ return irq;
>> >+ }
>> >+#endif
>> >+
> Can't the driver revert to single stage mode if platform_get_irq()
> fails? That way the value of 'irq' can be tested throughout the
> _probe() function and the #ifdefs removed.
I like that idea. The same can be done with the devm_request_irq()
call. It should definitely still display a warning if the command-line
option is set but no interrupt is available.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support fu.wei@linaro.org - 2016-02-03 18:30 +0100
Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-02-04 17:40 +0100
Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Timur Tabi <timur@codeaurora.org> - 2016-02-04 17:50 +0100
Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Fu Wei <fu.wei@linaro.org> - 2016-02-05 10:30 +0100
Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support Guenter Roeck <linux@roeck-us.net> - 2016-02-04 17:50 +0100
csiph-web