Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support

From	Fu Wei <fu.wei@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support
Date	2016-02-05 10:30 +0100
Message-ID	<qYKSf-6Mb-29@gated-at.bofh.it> (permalink)
References	<qY9pF-4WX-3@gated-at.bofh.it> <qY9pF-4WX-15@gated-at.bofh.it> <qYv6O-4s9-1@gated-at.bofh.it> <qYvgu-4wj-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 5 February 2016 at 00:43, Timur Tabi <timur@codeaurora.org> wrote:
> Mathieu Poirier wrote:
>>>
>>> >+#ifdef CONFIG_ARM_SBSA_WATCHDOG_PANIC
>>> >+       irq = platform_get_irq(pdev, 0);
>>> >+       if (irq < 0) {
>>> >+               dev_err(dev, "unable to get ws0 interrupt.\n");
>>> >+               return irq;
>>> >+       }
>>> >+#endif
>>> >+
>>
>> Can't the driver revert to single stage mode if platform_get_irq()
>> fails?  That way the value of 'irq' can be tested throughout the
>> _probe() function and the #ifdefs removed.
>
>
> I like that idea.  The same can be done with the devm_request_irq() call.
> It should definitely still display a warning if the command-line option is
> set but no interrupt is available.

Yes, I agree with that too, brilliant idea, this will be in v11 patchset



-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

Thread

[PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support fu.wei@linaro.org - 2016-02-03 18:30 +0100
  Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout  panic support Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-02-04 17:40 +0100
    Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout  panic support Timur Tabi <timur@codeaurora.org> - 2016-02-04 17:50 +0100
      Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout  panic support Fu Wei <fu.wei@linaro.org> - 2016-02-05 10:30 +0100
    Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout  panic support Guenter Roeck <linux@roeck-us.net> - 2016-02-04 17:50 +0100

csiph-web