Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency

Path	csiph.com!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Date	Wed, 03 Feb 2016 23:10:01 +0100
Message-ID	<qYdMB-7MT-7@gated-at.bofh.it> (permalink)
References	<qSYEz-5ea-29@gated-at.bofh.it> <qT5mF-1Ph-1@gated-at.bofh.it> <qY9SF-58b-1@gated-at.bofh.it> <qYcQy-7bF-13@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=iYYxtJkToxYLZBbfLGUX0oq0LdnIUGXRifMgndZGLNo=; b=totqBW0AfNL1aK7Z1i6ngmzNvRUxV25LF4Pv6VqOuugRbuiPMBVYlbWxIymx918ZeL cDQy/FDiWyxj5PiTG7VOaSqxRRWk6PqlGyRerCkNsGkKZo/UPnOKrT6x+TbLB4ceO/zM S7K3tEmyQkSTv2SfIJ2iYwStGZWJywmnvYw5dh/lV1z7YdwAY+eoFug74jkEAePJ0sJU g538WQCl27pIeXQRw1KhASBDMZo5ztPrAkGHvPR4e4MkOAjRjgFtLJwX0rWD77ElX49L /9v0lkBthlA00warcaREJ/LltJrPnqiZEt2PczHhwsnIsbvuOmVZeOIf7Vb5FauIQ5oM +ceA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=iYYxtJkToxYLZBbfLGUX0oq0LdnIUGXRifMgndZGLNo=; b=JG56Umo0tZWgjWm2C0XBjZZhze3FCkdeAR/x4u+g/waDius+duRZ3AP2NDg5rWqe42 OMH+j1pFh1VZeJuy1QGVcXokqtMBHgar5Tgyh89MrRBPW4L6B41ks9AcfH/qS3qJEPsX Lc2P0xUVLQY3KR9XZG+D0UoCKDCLXt003ODQulKXRcAm2VoaaOdaIneiwwoqibqjmO3M bEMv+v121eURL7mPIMDNBfuL5jejreJX8EPKlpXhVYUkbMZtXlHKKpYn0OsypNoeJi4j ajg264ZCt6g35UO23DBR+ml6YEwj8gVBeHBVGj+WzhRh4CjziyUFxrdCxLW8Z4sMeTsX kmIg==
X-Gm-Message-State	AG10YOT4cNDSwmlbBxCYAAZB2j9jI9KzFZHJ1k3/JCb6OlKHNT3tz4KlAV4Vu2pgXU186g==
X-Received	by 10.25.218.137 with SMTP id r131mr1663433lfg.63.1454537053273; Wed, 03 Feb 2016 14:04:13 -0800 (PST)
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/25.0.90.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	112
Organization	linux.* mail to news gateway
X-Original-Cc	Bin Liu <b-liu@ti.com>, Felipe Balbi <balbi@ti.com>, balbif@gmail.com, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 04 Feb 2016 00:04:07 +0200
X-Original-Message-ID	<87bn7xpi20.fsf@ti.com>
X-Original-References	<1749004.q1rSF7t8cz@wuerfel> <20160120180833.GA5433@uda0271908> <87wpqlptmt.fsf@ti.com> <9451477.tmYKHlsitn@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1325994

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

Arnd Bergmann <arnd@arndb.de> writes:
>> > On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
>> >> The phy-am335x driver accidentally selects 'USB_COMMON', which is
>> >> not correct as that symbol should indicate whether USB host or
>> >> target mode is enabled, but it might not:
>> >> 
>> >> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>> >
>> > Is it possible to have a .config which has either USB nor USB_GADGET
>> > set but AM335X_PHY_USB is set to be in the situation as in the warning
>> > above?
>> >
>> >> 
>> >> This changes the 'select' into 'depends on', as it should have
>> >> been initially.
>> >
>> > Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
>> > since USB_COMMON is an invisible option and its defualt is 'M'.
>> 
>> 
>> yeah, USB_COMMON is supposed to be selected, not depended upon.
>
>
> That means we should do something like the patch below?
>
> Fine with me too, but maybe you can write the changelog for that,
> as I don't know the background behind the logic.
>
> 	Arnd
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index e7e117d5dbbe..df005f5a0e0c 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -249,7 +249,8 @@ config PHY_SUN9I_USB
>  	tristate "Allwinner sun9i SoC USB PHY driver"
>  	depends on ARCH_SUNXI && HAS_IOMEM && OF
>  	depends on RESET_CONTROLLER
> -	depends on USB_COMMON
> +	depends on USB_SUPPORT
> +	select USB_COMMON
>  	select GENERIC_PHY
>  	help
>  	  Enable this to support the transceiver that is part of Allwinner
> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
> index 8ed451dd651e..8689dcba5201 100644
> --- a/drivers/usb/Kconfig
> +++ b/drivers/usb/Kconfig
> @@ -31,8 +31,6 @@ if USB_SUPPORT
>  
>  config USB_COMMON
>  	tristate
> -	default y
> -	depends on USB || USB_GADGET
>  
>  config USB_ARCH_HAS_HCD
>  	def_bool y
> @@ -41,6 +39,7 @@ config USB_ARCH_HAS_HCD
>  config USB
>  	tristate "Support for Host-side USB"
>  	depends on USB_ARCH_HAS_HCD
> +	select USB_COMMON
>  	select NLS  # for UTF-8 strings
>  	---help---
>  	  Universal Serial Bus (USB) is a specification for a serial bus
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index af5d922a8f5d..2057add439f0 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -15,6 +15,7 @@
>  
>  menuconfig USB_GADGET
>  	tristate "USB Gadget Support"
> +	select USB_COMMON
>  	select NLS
>  	help
>  	   USB is a master/slave protocol, organized with one master

looks great to me. Care to send it in proper patch form ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Felipe Balbi <balbi@kernel.org> - 2016-02-03 19:00 +0100
  Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:10 +0100
    Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Felipe Balbi <balbi@kernel.org> - 2016-02-03 23:10 +0100

csiph-web