Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency

From	Felipe Balbi <balbi@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency
Date	2016-02-03 19:00 +0100
Message-ID	<qY9SF-58b-1@gated-at.bofh.it> (permalink)
References	<qSYEz-5ea-29@gated-at.bofh.it> <qT5mF-1Ph-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

hi,

Bin Liu <b-liu@ti.com> writes:
> On Wed, Jan 20, 2016 at 11:56:34AM +0100, Arnd Bergmann wrote:
>> The phy-am335x driver accidentally selects 'USB_COMMON', which is
>> not correct as that symbol should indicate whether USB host or
>> target mode is enabled, but it might not:
>> 
>> warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
>
> Is it possible to have a .config which has either USB nor USB_GADGET
> set but AM335X_PHY_USB is set to be in the situation as in the warning
> above?
>
>> 
>> This changes the 'select' into 'depends on', as it should have
>> been initially.
>
> Using 'depends on' causes AM335x_PHY_USB driver unable to built-in,
> since USB_COMMON is an invisible option and its defualt is 'M'.


yeah, USB_COMMON is supposed to be selected, not depended upon.

-- 
balbi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Felipe Balbi <balbi@kernel.org> - 2016-02-03 19:00 +0100
  Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:10 +0100
    Re: [PATCH] usb: phy-am335x: clarify USB_COMMON dependency Felipe Balbi <balbi@kernel.org> - 2016-02-03 23:10 +0100

csiph-web