Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables
Date	2016-02-05 17:40 +0100
Message-ID	<qYRAn-2Gm-41@gated-at.bofh.it> (permalink)
References	<qYuNt-4ix-19@gated-at.bofh.it> <qYuX9-4mU-27@gated-at.bofh.it> <qYPfc-1gO-9@gated-at.bofh.it> <qYPRU-1xp-13@gated-at.bofh.it> <qYRh0-2zl-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 5 Feb 2016 17:18:34 +0100
Petr Mladek <pmladek@suse.com> wrote:

> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index a138f6d..de6dab0 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -449,7 +449,7 @@ config PROBE_EVENTS
>  	def_bool n
>  
>  config DYNAMIC_FTRACE
> -	bool "enable/disable function tracing dynamically"
> +	bool "Enable/Disable function tracing dynamically"
>  	depends on FUNCTION_TRACER
>  	depends on HAVE_DYNAMIC_FTRACE
>  	default y
> @@ -472,9 +472,17 @@ config DYNAMIC_FTRACE
>  	  otherwise has native performance as long as no tracing is active.
>  
>  config DYNAMIC_FTRACE_WITH_REGS
> -	def_bool y
> +	bool "Pass registers to function tracer"
>  	depends on DYNAMIC_FTRACE
>  	depends on HAVE_DYNAMIC_FTRACE_WITH_REGS
> +	default y
> +	help
> +	  This option enables passing the current state of processor
> +	  registers to the function tracer. It allows to do a more
> +	  detailed analyze and print more information.
> +
> +	  Say Y here if you are unsure. The only exception is if
> +	  you want to pass a build error caused by a broken compiler.
>  
>  config FUNCTION_PROFILER
>  	bool "Kernel function profiler"
> 
> 
> I made "enable/disable" uppercase because it looked weird in
> context of other descritions.
> 

This works too, and I'm fine with it.

-- Steve

Thread

[PATCH v7 00/10] ftrace with regs + live patching for ppc64 LE (ABI v2) Torsten Duwe <duwe@lst.de> - 2016-02-04 17:20 +0100
  [PATCH v7 03/10] ppc use ftrace_modify_all_code default Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 02/10] ppc64le FTRACE_WITH_REGS implementation Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 08/10] Implement kernel live patching for ppc64le (ABIv2) Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 06/10] ppc64 ftrace: disable profiling for some functions Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
    Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-05 15:10 +0100
      Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-05 15:50 +0100
        Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-05 17:20 +0100
          Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-05 17:40 +0100
          Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-06 11:40 +0100
            Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 11:40 +0100
              Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-08 13:20 +0100
                Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 16:30 +0100
                Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-08 16:50 +0100
                Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 17:40 +0100
                Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-09 10:10 +0100
  [PATCH v7 10/10] livepatch: Detect offset for the ftrace location  during build Petr Mladek <pmladek@suse.com> - 2016-02-04 17:30 +0100
  [PATCH v7 07/10] ppc64 ftrace: disable profiling for some files Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 01/10] ppc64 (le): prepare for -mprofile-kernel Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 09/10] Enable LIVEPATCH to be configured on ppc64le and add  livepatch.o if it is selected. Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
  [PATCH v7 05/10] ppc64 ftrace_with_regs: spare early boot and low  level Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100

csiph-web