Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1327812
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables |
| Date | 2016-02-05 15:50 +0100 |
| Message-ID | <qYPRU-1xp-13@gated-at.bofh.it> (permalink) |
| References | <qYuNt-4ix-19@gated-at.bofh.it> <qYuX9-4mU-27@gated-at.bofh.it> <qYPfc-1gO-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 5 Feb 2016 15:05:17 +0100 Petr Mladek <pmladek@suse.com> wrote: > On Mon 2016-01-25 16:29:54, Torsten Duwe wrote: > > diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c > > index ef8b916..29b7014 100644 > > --- a/arch/powerpc/kernel/ftrace.c > > +++ b/arch/powerpc/kernel/ftrace.c > > @@ -28,6 +28,11 @@ > > > > > > #ifdef CONFIG_DYNAMIC_FTRACE > > +#if defined(CONFIG_DYNAMIC_FTRACE_WITH_REGS) && defined(CONFIG_PPC64) && \ > > + !defined(CC_USING_MPROFILE_KERNEL) > > +#error "DYNAMIC_FTRACE_WITH_REGS requires working -mprofile-kernel" > > +#endif > > CONFIG_DYNAMIC_FTRACE_WITH_REGS is automatically enabled when > both CONFIG_DYNAMIC_FTRACE and HAVE_DYNAMIC_FTRACE_WITH_REGS > are enabled. > > Therefore it is not possible to build kernel with broken gcc > and DYNAMIC_FTRACE. > > IMHO, we need to allow to explicitely disable DYNAMIC_FTRACE_WITH_REGS > if the compiler is broken to get around this build error. > > We either need to define DYNAMIC_FTRACE_WITH_REGS as a proper > bool with description, help text, ... Or we need a way to > explicitely disable HAVE_DYNAMIC_FTRACE_WITH_REGS. Or something > like this. > You mean something like this? (not tested) -- Steve diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig index e45db6b0d878..19377bacebfc 100644 --- a/kernel/trace/Kconfig +++ b/kernel/trace/Kconfig @@ -470,6 +470,19 @@ config DYNAMIC_FTRACE_WITH_REGS def_bool y depends on DYNAMIC_FTRACE depends on HAVE_DYNAMIC_FTRACE_WITH_REGS + depends on !DISABLE_DYNAMIC_FTRACE_WITH_REGS + +config DISABLE_DYNAMIC_FTRACE_WITH_REGS + bool "Force build to not have function tracer pass in registers" + depends on DYNAMIC_FTRACE + depends on HAVE_DYNAMIC_FTRACE_WITH_REGS + help + If the architecture supports passing in registers to the function + tracer, then that is automatically enabled. But there may be some + compilers out there that are broken and cause this to fail. + This option makes the build think that the architecture does not + support the register passing and allows the build to work even + with compilers that do not support the feature.g config FUNCTION_PROFILER bool "Kernel function profiler"
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v7 00/10] ftrace with regs + live patching for ppc64 LE (ABI v2) Torsten Duwe <duwe@lst.de> - 2016-02-04 17:20 +0100
[PATCH v7 03/10] ppc use ftrace_modify_all_code default Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 02/10] ppc64le FTRACE_WITH_REGS implementation Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 08/10] Implement kernel live patching for ppc64le (ABIv2) Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 06/10] ppc64 ftrace: disable profiling for some functions Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-05 15:10 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-05 15:50 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-05 17:20 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-05 17:40 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-06 11:40 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 11:40 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-08 13:20 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 16:30 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Steven Rostedt <rostedt@goodmis.org> - 2016-02-08 16:50 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Petr Mladek <pmladek@suse.com> - 2016-02-08 17:40 +0100
Re: [PATCH v7 04/10] ppc64 ftrace_with_regs configuration variables Torsten Duwe <duwe@lst.de> - 2016-02-09 10:10 +0100
[PATCH v7 10/10] livepatch: Detect offset for the ftrace location during build Petr Mladek <pmladek@suse.com> - 2016-02-04 17:30 +0100
[PATCH v7 07/10] ppc64 ftrace: disable profiling for some files Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 01/10] ppc64 (le): prepare for -mprofile-kernel Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 09/10] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected. Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
[PATCH v7 05/10] ppc64 ftrace_with_regs: spare early boot and low level Torsten Duwe <duwe@lst.de> - 2016-02-04 17:30 +0100
csiph-web