Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327461

Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar

Show all headers | View raw

> > But would actually anything use it?
> 
> You mean, would anything actually use the lspci output?  I don't know,
> but why would we want it to print garbage?

In he kernel. I don't think lspci is that interesting.
> 
> And the kernel certainly uses the struct resource.  Setting
> IORESOURCE_PCI_FIXED is not a way of saying "please ignore this
> resource."

There is already another quirk that uses the same technique to handle
a bad bar. I also didn't notice any bad side effects. Again what would it be
used for?

I looked into the new device ops you asked for, but it is fairly
complicated as the ops are not per device but per bus, and there
can be many copies of this device, and the pci_dev is not passed,
so it needs complicated pattern matching on the devfn.

Doing it like the existing quirk is much simpler, and seems to work
just fine.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-04 18:50 +0100
  Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Andi Kleen <ak@linux.intel.com> - 2016-02-04 20:00 +0100
    Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 03:00 +0100
      Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Andi Kleen <andi@firstfloor.org> - 2016-02-05 04:40 +0100
        Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 17:40 +0100

csiph-web