Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327397

Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar

Show all headers | View raw

On Thu, Feb 04, 2016 at 10:54:42AM -0800, Andi Kleen wrote:
> > It sounds like these devices have some device-specific register where
> > BAR 0 is supposed to be?  Setting IORESOURCE_PCI_FIXED doesn't seem
> > like the right solution to me.  Even if we set that, the core still
> 
> There is no actually functional register on these locations that has any side
> effects.
> 
> > believes this resource corresponds to some address space consumed by
> > the device.  I think we will still try to size the BAR and decode its
> > type.  I think it will still show up via lspci.  That's all
> > meaningless.
> 
> But would actually anything use it?

You mean, would anything actually use the lspci output?  I don't know,
but why would we want it to print garbage?

And the kernel certainly uses the struct resource.  Setting
IORESOURCE_PCI_FIXED is not a way of saying "please ignore this
resource."

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-04 18:50 +0100
  Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Andi Kleen <ak@linux.intel.com> - 2016-02-04 20:00 +0100
    Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 03:00 +0100
      Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Andi Kleen <andi@firstfloor.org> - 2016-02-05 04:40 +0100
        Re: [PATCH] x86, pci: Add quirk for unsizeable Broadwell EP bar Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 17:40 +0100

csiph-web