Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1325588

Re: [PATCH v3] net:Add sysctl_max_skb_frags

Show all headers | View raw

On Wed, 2016-02-03 at 07:58 -0800, Alexander Duyck wrote:
> > +++ b/net/core/sysctl_net_core.c
> 
> I really don't think these changes belong in the core. Below you only
> modify the TCP code path so this more likely belongs in the TCP path
> unless you are going to guarantee that all other code paths obey the
> sysctl.  It probably belongs in net/ipv4/sysctl_net_ipv4.c


Alexander, this is a v3.

We rejected prior attempts doing exactly what you suggest.

Think about GRO : These people also need to use the same sysctl in GRO
to limit number of frags.

Limiting the stuff at the egress is useless in forwarding setups.
It will be too late as they'll need to linearize -> huge performance
drop.

This is why we wanted a global setup so that these guys can tweak the
default limit.

Please read netdev history about this stuff.

Plan of action :

1) This patch, adding a core sysctl.
2) Use it in TCP (already done in this patch)
3) Use it in GRO

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] net:Add sysctl_max_skb_frags Hans Westgaard Ry <hans.westgaard.ry@oracle.com> - 2016-02-03 09:30 +0100
  Re: [PATCH v3] net:Add sysctl_max_skb_frags Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-03 12:30 +0100
    Re: [PATCH v3] net:Add sysctl_max_skb_frags Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 12:40 +0100
      Re: [PATCH v3] net:Add sysctl_max_skb_frags Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-03 13:30 +0100
        Re: [PATCH v3] net:Add sysctl_max_skb_frags Hannes Frederic Sowa <hannes@stressinduktion.org> - 2016-02-03 15:10 +0100
        Re: [PATCH v3] net:Add sysctl_max_skb_frags Eric Dumazet <eric.dumazet@gmail.com> - 2016-02-03 15:40 +0100
        RE: [PATCH v3] net:Add sysctl_max_skb_frags David Laight <David.Laight@ACULAB.COM> - 2016-02-03 18:40 +0100
  Re: [PATCH v3] net:Add sysctl_max_skb_frags Alexander Duyck <alexander.duyck@gmail.com> - 2016-02-03 17:00 +0100
    Re: [PATCH v3] net:Add sysctl_max_skb_frags Eric Dumazet <eric.dumazet@gmail.com> - 2016-02-03 17:10 +0100
      Re: [PATCH v3] net:Add sysctl_max_skb_frags Alexander Duyck <alexander.duyck@gmail.com> - 2016-02-03 18:50 +0100
        Re: [PATCH v3] net:Add sysctl_max_skb_frags Eric Dumazet <eric.dumazet@gmail.com> - 2016-02-03 19:00 +0100
          Re: [PATCH v3] net:Add sysctl_max_skb_frags Alexander Duyck <alexander.duyck@gmail.com> - 2016-02-03 19:30 +0100
            Re: [PATCH v3] net:Add sysctl_max_skb_frags Eric Dumazet <eric.dumazet@gmail.com> - 2016-02-03 20:30 +0100
              Re: [PATCH v3] net:Add sysctl_max_skb_frags Alexander Duyck <alexander.duyck@gmail.com> - 2016-02-03 22:10 +0100
  Re: [PATCH v3] net:Add sysctl_max_skb_frags David Miller <davem@davemloft.net> - 2016-02-09 10:40 +0100

csiph-web