RE: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets

From	David Laight <David.Laight@ACULAB.COM>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets
Date	2016-02-03 18:00 +0100
Message-ID	<qY8WD-4vK-25@gated-at.bofh.it> (permalink)
References	<qY4pY-1KZ-15@gated-at.bofh.it> <qY4pZ-1KZ-37@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Paul Burton
> Sent: 03 February 2016 12:03
> Resets of the EG20T MAC on the MIPS Boston development board take longer
> than the 1000 loops that pch_gbe_wait_clr_bit was performing. Bump up
> the number of loops.
...
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-
> semi/pch_gbe/pch_gbe_main.c
> index 00ef83c..87994d2 100644
> --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> @@ -321,7 +321,7 @@ static void pch_gbe_wait_clr_bit(void *reg, u32 bit)
>  	u32 tmp;
> 
>  	/* wait busy */
> -	tmp = 1000;
> +	tmp = 10000;
>  	while ((ioread32(reg) & bit) && --tmp)
>  		cpu_relax();
>  	if (!tmp)

Why not sleep for (say) 100us ?
That'll stop the loop depending on the cpu speed.

	David

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 6/6] net: pch_gbe: Allow longer for resets Paul Burton <paul.burton@imgtec.com> - 2016-02-03 13:10 +0100
  RE: [PATCH v2 6/6] net: pch_gbe: Allow longer for resets David Laight <David.Laight@ACULAB.COM> - 2016-02-03 18:00 +0100

csiph-web