Re: [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr

From	Matias Bjørling <mb@lightnvm.io>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr
Date	2016-02-03 10:00 +0100
Message-ID	<qY1s6-83z-7@gated-at.bofh.it> (permalink)
References	<qXk3L-1dK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/01/2016 11:34 AM, Javier González wrote:
> Add a warning if irqs are disabled when locking a new address in rrpc.
> The typical path to a new request does not disable irqs, but this is not
> guaranteed in the future.
> 
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>  drivers/lightnvm/rrpc.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h
> index dfca5c4..c27283a 100644
> --- a/drivers/lightnvm/rrpc.h
> +++ b/drivers/lightnvm/rrpc.h
> @@ -184,6 +184,8 @@ static int __rrpc_lock_laddr(struct rrpc *rrpc, sector_t laddr,
>  	sector_t laddr_end = laddr + pages - 1;
>  	struct rrpc_inflight_rq *rtmp;
>  
> +	WARN_ON(irqs_disabled());
> +
>  	spin_lock_irq(&rrpc->inflights.lock);
>  	list_for_each_entry(rtmp, &rrpc->inflights.reqs, list) {
>  		if (unlikely(request_intersects(rtmp, laddr, laddr_end))) {
> 

Thanks, applied for next -rc.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr "Javier González" <jg@lightnvm.io> - 2016-02-01 11:40 +0100
  [PATCH 2/2] lightnvm: fix request intersection locking in rrpc "Javier González" <jg@lightnvm.io> - 2016-02-01 11:40 +0100
    Re: [PATCH 2/2] lightnvm: fix request intersection locking in rrpc Matias Bjørling <mb@lightnvm.io> - 2016-02-03 10:00 +0100
  Re: [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr Matias Bjørling <mb@lightnvm.io> - 2016-02-03 10:00 +0100

csiph-web