Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1325067

Re: [PATCH 2/2] lightnvm: fix request intersection locking in rrpc

Show all headers | View raw

On 02/01/2016 11:34 AM, Javier González wrote:
> This patch fixes an error on the calculation of intersecting logical
> addresses; it contemplates the case where a new request including
> several addresses intersects with a single locked address. This case is
> typical when multiple pages are sent in a new request, while GC - which
> at the moment sends one address at the time - is running.
> 
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
>  drivers/lightnvm/rrpc.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/rrpc.h b/drivers/lightnvm/rrpc.h
> index c27283a..3989d65 100644
> --- a/drivers/lightnvm/rrpc.h
> +++ b/drivers/lightnvm/rrpc.h
> @@ -174,8 +174,7 @@ static inline sector_t rrpc_get_sector(sector_t laddr)
>  static inline int request_intersects(struct rrpc_inflight_rq *r,
>  				sector_t laddr_start, sector_t laddr_end)
>  {
> -	return (laddr_end >= r->l_start && laddr_end <= r->l_end) &&
> -		(laddr_start >= r->l_start && laddr_start <= r->l_end);
> +	return (laddr_end >= r->l_start) && (laddr_start <= r->l_end);
>  }
>  
>  static int __rrpc_lock_laddr(struct rrpc *rrpc, sector_t laddr,
> 
Thanks, applied for next -rc.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr "Javier González" <jg@lightnvm.io> - 2016-02-01 11:40 +0100
  [PATCH 2/2] lightnvm: fix request intersection locking in rrpc "Javier González" <jg@lightnvm.io> - 2016-02-01 11:40 +0100
    Re: [PATCH 2/2] lightnvm: fix request intersection locking in rrpc Matias Bjørling <mb@lightnvm.io> - 2016-02-03 10:00 +0100
  Re: [PATCH 1/2] lightnvm: warn if irqs are disabled in lock laddr Matias Bjørling <mb@lightnvm.io> - 2016-02-03 10:00 +0100

csiph-web