Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325033
| Path | csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Viresh Kumar <viresh.kumar@linaro.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats |
| Date | Wed, 03 Feb 2016 09:30:01 +0100 |
| Message-ID | <qY0Z3-7Sl-3@gated-at.bofh.it> (permalink) |
| References | <qXP7A-7Ux-7@gated-at.bofh.it> <qXP7B-7Ux-13@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jGfjOQmEC6nJF+YkuK5MWcf6/0d2QaxO8kKZQN+1mw0=; b=DVlsRgyi9JeFwk9K1S3dzbYL1/u1pMP9iW/CGTLkpy08rZyLcEr8XcZKuAFrLEUeB4 kkWxqHEbrKlKB4upEYjUTnJoIv5sWvreHIUSnFIcUaO/TyCwdixz5n/+m7z/HaPioqKk 6QsSqab48lWoGkWhevtVGy1G3MEWrbDVh9vVo= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=jGfjOQmEC6nJF+YkuK5MWcf6/0d2QaxO8kKZQN+1mw0=; b=HeVVYcjBkjBzn97uWWA9cXY59HB/QmhJhHbBwhgg2utErgg7xZidO/HHxKIB9/b9cM 9PF0PsFkDXs8xzX/J7Yxjzkdq8PVvMPXdOI6TZtYVcAX5BuLNomxTCSxB6b5AzPMBgYL Qi6frGjnDPvB/RBdSKB2x6QvSxlMX/3TG983GIpjStIvKR0czJrJPjICxPFW5IoxR9c5 AxpChbBiLWR+F/OH6zvIgXm94mpIrlBfTP7T/9tyZ0oDwi8E+h7OesVfVXcr4GLX1d++ peUkOc5ctJsdGcpR4e/r/cVBzLV8R3O4sbD3nc0D8wQUBTyDK9GhI5FIweC4JPWpMZ9v 0+Tg== |
| X-Gm-Message-State | AG10YOS0aNqrxXZH6OQJxOlbY29+H1lyEKGl/IsNAVGyBG/2oq33g1TsIXxSdpWgbbQh6WAJ |
| X-Received | by 10.98.8.74 with SMTP id c71mr312232pfd.155.1454488023783; Wed, 03 Feb 2016 00:27:03 -0800 (PST) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.23 (2014-03-12) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 54 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, linux-pm@vger.kernel.org, pc@us.ibm.com, anton@samba.org, ego@linux.vnet.ibm.com, shreyas@linux.vnet.ibm.com, bsingharora@gmail.com, mpe@ellerman.id.au, linux-api@vger.kernel.org |
| X-Original-Date | Wed, 3 Feb 2016 13:57:00 +0530 |
| X-Original-Message-ID | <20160203082700.GZ31828@vireshk> |
| X-Original-References | <1454442102-1229-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <1454442102-1229-7-git-send-email-shilpa.bhat@linux.vnet.ibm.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1325033 |
Show key headers only | View raw
On 03-02-16, 01:11, Shilpasri G Bhat wrote:
> static int init_chip_info(void)
> {
> unsigned int chip[256];
> - unsigned int cpu, i;
> + unsigned int cpu;
> unsigned int prev_chip_id = UINT_MAX;
> cpumask_t cpu_mask;
> - int ret = -ENOMEM;
> + int i, j, ret = -ENOMEM;
>
> core_to_chip_map = kcalloc(cpu_nr_cores(), sizeof(unsigned int),
> GFP_KERNEL);
> @@ -583,12 +711,51 @@ static int init_chip_info(void)
> goto free_chip_map;
>
> for (i = 0; i < nr_chips; i++) {
> + char name[10];
> +
> chips[i].id = chip[i];
> cpumask_copy(&chips[i].mask, cpumask_of_node(chip[i]));
> INIT_WORK(&chips[i].throttle, powernv_cpufreq_work_fn);
> +
> + for (j = 0; j <= OCC_MAX_THROTTLE_STATUS; j++) {
> + chips[i].reason[j] =
> + kcalloc(powernv_pstate_info.nr_pstates,
> + sizeof(int), GFP_KERNEL);
> + if (!chips[i].reason[j]) {
> + ret = -ENOMEM;
> + goto free_chip;
> + }
> + }
> +
> + snprintf(name, sizeof(name), "chip%d", chips[i].id);
> + ret = kobject_init_and_add(&chips[i].kobj,
> + get_ktype(cpufreq_global_kobject),
Sorry but why do you need to create a kobject here ? A simple
sysfs_create_group() can create groups (directories) for you.
> + cpufreq_global_kobject, name);
> + if (ret)
> + goto free_chip;
> +
> + ret = sysfs_create_group(&chips[i].kobj, &throttle_stat_group);
> + if (ret) {
> + pr_info("Chip %d failed to create throttle sysfs group\n",
> + chips[i].id);
> + goto free_kobject;
> + }
> }
--
viresh
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-02 20:50 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 09:30 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-03 09:50 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 10:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-02-03 13:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 15:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-03 17:30 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-04 03:00 +0100
csiph-web