Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325306
| From | Gautham R Shenoy <ego@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats |
| Date | 2016-02-03 13:10 +0100 |
| Message-ID | <qY4pX-1KZ-1@gated-at.bofh.it> (permalink) |
| References | <qXP7A-7Ux-7@gated-at.bofh.it> <qXP7B-7Ux-13@gated-at.bofh.it> <qY0Z3-7Sl-3@gated-at.bofh.it> <qY1ip-80l-15@gated-at.bofh.it> <qY1BL-8mh-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Viresh, > > What I can suggest is: > - Move this directory inside cpuX/cpufreq/ directory, in a similar way > as to how we create 'stats' directory today. > - You can then get policy->cpu, to get chip->id out of it. > - The only disadvantage here is that the same chip directory will be > replicated in multiple policies, but that makes it more readable. Thinking about it, having a sysfs group attached to a policy kobject looks ok if replication of the same chip information across multiple policies is not objectionable. Regarding the table-format, it breaks the sysfs's one-value-per-file rule. So I would still prefer each throttle reason being a separate file which gives the number of times the chip frequency was throttled due to that reason. We can live without the per-frequency throttle stats listed in the throttle_status. So, would the following be sysfs group structure be acceptable? $ls -1 /sys/devices/system/cpu/cpuX/cpufreq/throttle_stats/ unthrottle powercap overtemp supply_fault overcurrent occ_reset turbo_stat sub_turbo_stat -- Thanks and Regards gautham.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-02 20:50 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 09:30 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-03 09:50 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 10:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Gautham R Shenoy <ego@linux.vnet.ibm.com> - 2016-02-03 13:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-03 15:10 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-02-03 17:30 +0100
Re: [PATCH v8 6/6] cpufreq: powernv: Add sysfs attributes to show throttle stats Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-04 03:00 +0100
csiph-web