Re: [PATCH 05/12] m68k: move exports to definitions

From	Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/12] m68k: move exports to definitions
Date	2016-02-01 16:00 +0100
Message-ID	<qXo7p-4jK-37@gated-at.bofh.it> (permalink)
References	<qWmKl-7Pd-9@gated-at.bofh.it> <qWmU3-7SX-37@gated-at.bofh.it> <qXkn7-1my-1@gated-at.bofh.it> <qXlCy-2xe-5@gated-at.bofh.it> <qXmS0-3vq-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 01, 2016 at 02:30:16PM +0100, Geert Uytterhoeven wrote:
> The kernel has all the *di3 variants:
> 
> 002eae2c T __ashldi3
> 002eae70 T __ashrdi3
> 002eaebc T __lshrdi3
> 002eaf00 T __muldi3
> 0038a6d0 R __ksymtab___ashldi3
> 0038a6d8 R __ksymtab___ashrdi3
> 0038ab68 R __ksymtab___lshrdi3
> 0038ab90 R __ksymtab___muldi3
> 003a8a5a r __kstrtab___ashldi3
> 003a8a64 r __kstrtab___ashrdi3
> 003a8a6e r __kstrtab___lshrdi3
> 003a8a78 r __kstrtab___muldi3
> 
> Hence the *si3 are missing:
> 
> __divsi3
> __modsi3
> __mulsi3
> __udivsi3
> __umodsi3

Does your .config have CPU_HAS_NO_MULDIV64?  Because otherwise these objects
won't be built and their exports had been conditional on that as well:

#if defined(CONFIG_CPU_HAS_NO_MULDIV64)
/*
 * Simpler 68k and ColdFire parts also need a few other gcc functions.
 */
extern long long __divsi3(long long, long long);
extern long long __modsi3(long long, long long);
extern long long __mulsi3(long long, long long);
extern long long __udivsi3(long long, long long);
extern long long __umodsi3(long long, long long);

EXPORT_SYMBOL(__divsi3);
EXPORT_SYMBOL(__modsi3);
EXPORT_SYMBOL(__mulsi3);
EXPORT_SYMBOL(__udivsi3);
EXPORT_SYMBOL(__umodsi3);
#endif

is what we have in mainline m68k_ksyms.c.  Neither allmodconfig, nor any of
defconfigs have it.  And on a coldfire build they are built and exported as
expected:
$ grep si3 ../build/coldfire/System.map 
002be860 T __divsi3
002be890 T __modsi3
002be8b8 T __mulsi3
002be8dc T __udivsi3
002be90c T __umodsi3
003ed960 R __ksymtab___divsi3
003edc80 R __ksymtab___modsi3
003edca8 R __ksymtab___mulsi3
003edff8 R __ksymtab___udivsi3
003ee000 R __ksymtab___umodsi3
003f7ba4 r __kcrctab___divsi3
003f7d34 r __kcrctab___modsi3
003f7d48 r __kcrctab___mulsi3
003f7ef0 r __kcrctab___udivsi3
003f7ef4 r __kcrctab___umodsi3
004144fe r __kstrtab___divsi3
00414507 r __kstrtab___modsi3
00414510 r __kstrtab___mulsi3
00414519 r __kstrtab___udivsi3
00414523 r __kstrtab___umodsi3

Thread

[RFC][PATCHSET] allowing exports in *.S Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
  [PATCH 02/12] EXPORT_SYMBOL() for asm Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
    Re: [PATCH 02/12] EXPORT_SYMBOL() for asm Arnd Bergmann <arnd@arndb.de> - 2016-01-29 22:10 +0100
    Re: [PATCH 02/12] EXPORT_SYMBOL() for asm David Howells <dhowells@redhat.com> - 2016-02-01 16:20 +0100
  [PATCH 12/12] sparc32: debride memcpy.S a bit Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
    Re: [PATCH 12/12] sparc32: debride memcpy.S a bit David Miller <davem@davemloft.net> - 2016-01-30 08:10 +0100
  [PATCH 11/12] [sparc] unify 32bit and 64bit string.h Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
    Re: [PATCH 11/12] [sparc] unify 32bit and 64bit string.h David Miller <davem@davemloft.net> - 2016-01-30 08:10 +0100
  [PATCH 01/12] [kbuild] handle exports in lib-y objects reliably Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
  [PATCH 07/12] arm: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:20 +0100
  [PATCH 03/12] x86: move exports to actual definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
    Re: [PATCH 03/12] x86: move exports to actual definitions Thomas Gleixner <tglx@linutronix.de> - 2016-02-01 09:20 +0100
  [PATCH 08/12] ppc: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
  [PATCH 05/12] m68k: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
    Re: [PATCH 05/12] m68k: move exports to definitions Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-01 12:00 +0100
      Re: [PATCH 05/12] m68k: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-01 13:20 +0100
        Re: [PATCH 05/12] m68k: move exports to definitions Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-01 14:40 +0100
          Re: [PATCH 05/12] m68k: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-01 16:00 +0100
            Re: [PATCH 05/12] m68k: move exports to definitions Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-01 16:40 +0100
  [PATCH 04/12] alpha: move exports to actual definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
  [PATCH 10/12] ia64: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
  [PATCH 06/12] s390: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
    Re: [PATCH 06/12] s390: move exports to definitions Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-02-02 12:40 +0100
  [PATCH 09/12] sparc: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-29 20:30 +0100
    Re: [PATCH 09/12] sparc: move exports to definitions David Miller <davem@davemloft.net> - 2016-01-30 08:10 +0100
  [RFC][PATCHSET v2] allowing exports in *.S Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 12/13] sparc32: debride memcpy.S a bit Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 04/13] alpha: move exports to actual definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 03/13] x86: move exports to actual definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 09/13] ppc: get rid of unreachable abs() implementation Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 11/13] [sparc] unify 32bit and 64bit string.h Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 10/13] sparc: move exports to definitions Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
    [PATCH v2 02/13] EXPORT_SYMBOL() for asm Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-03 22:30 +0100
      Re: [PATCH v2 02/13] EXPORT_SYMBOL() for asm Al Viro <viro@ZenIV.linux.org.uk> - 2016-02-04 19:10 +0100

csiph-web