[PATCH 4/4] hibernate: fix disk and module leak on successfull resume

From	Roman Pen <roman.penyaev@profitbricks.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/4] hibernate: fix disk and module leak on successfull resume
Date	2016-02-01 16:00 +0100
Message-ID	<qXo7p-4jK-33@gated-at.bofh.it> (permalink)
References	<qXo7o-4jK-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Do not forget to put the disk back.

Signed-off-by: Roman Pen <roman.penyaev@profitbricks.com>
Cc: Gi-Oh Kim <gi-oh.kim@profitbricks.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 kernel/power/hibernate.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index b7342a2..1f53dc2 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -785,8 +785,11 @@ static int software_resume(void)
 	 */
 	if (isdigit(resume_file[0]) && resume_wait) {
 		int partno;
-		while (!get_gendisk(swsusp_resume_device, &partno))
+		struct gendisk *disk;
+
+		while (!(disk = get_gendisk(swsusp_resume_device, &partno)))
 			msleep(10);
+		put_gendisk(disk);
 	}
 
 	if (!swsusp_resume_device) {
-- 
2.6.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/4] hibernate: fix disk and module leak on successfull resume Roman Pen <roman.penyaev@profitbricks.com> - 2016-02-01 16:00 +0100
  Re: [PATCH 4/4] hibernate: fix disk and module leak on successfull resume "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-02-03 02:40 +0100

csiph-web