[PATCH 0/4] introduce new put_getdisk() call

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Roman Pen <roman.penyaev@profitbricks.com>
Newsgroups	linux.kernel
Subject	[PATCH 0/4] introduce new put_getdisk() call
Date	Mon, 01 Feb 2016 16:00:03 +0100
Message-ID	<qXo7o-4jK-3@gated-at.bofh.it> (permalink)
X-Original-To	unlisted-recipients:; (no To-header on input)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=profitbricks-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=S7mMYR2uXi5JPqf+hT65vQ8a/jrfsyM75bsS1aW5WaU=; b=nHhrTFiF1pUh2JLRDRSKT0qN+GmcLfETJyVdw8m8OadxeKk0O4n8mZH0LMbAjo0Qvy jgilYXMzLLD+7r+X4Km1AkmZSIfruyPiFFxdgxOP2pG1HjRk7XX9AK9pPGyQ8A5U6u1R cJax5IWaMdVijAoSJOFUf+Z/GdnHTjum2QKr1y2nDcLpHnvmkMYC7SCL7NFtB0FpKGXK EwlTMkeQeUV7Kh7r77Zx2DeANJbZNTCgTqgb5WsVH5QMWUDVs2ZVHvEjOVDJyLwfAp1r Ois4qeDtiCJ/YAhLT+jjANB01aMs24Wbslw0joQqup4NJWrwkOo+D69UkqwWWvCFuYpM Kskw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=S7mMYR2uXi5JPqf+hT65vQ8a/jrfsyM75bsS1aW5WaU=; b=O3LFLQVgEBLfnmu1UfdVbsBmJtoiB7J1JZ7XELnO7sSraZ+mh63rH8bmEYI5mViNr4 vG2LcAmVT/zKkcIriy0Sgiu6XZ6wufhbQxijxm94TKESsHqJsHrohdGymDk6tBrqm9uj MrKHAiXQwPu6BkAYBL9CnhmFssmWDVthwx2Btsf5L2H3NnypIqoM0hxMydeYN65btBet EcYCeT2g17UtCQpMuwCmeeAPVMSgXv43mt8pRysghndoa+h/yxl0LoYTu5N1oFQafnrW 1vcx8WG+QALyQMJN/Cf9dvp5kKBJT24MHPuf4SuYUkOESD1FKQ2WPSaKsZgUDQiqGr5T a/NQ==
X-Gm-Message-State	AG10YOSKJcexTnvq+zFY55DtdIuUCokGqE9KxnN71AZqSz9bGPwzfV0Ndxkj3yb/7ZebUnXZ
X-Received	by 10.28.184.137 with SMTP id i131mr11645463wmf.96.1454338335822; Mon, 01 Feb 2016 06:52:15 -0800 (PST)
X-Mailer	git-send-email 2.6.2
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	51
Organization	linux.* mail to news gateway
X-Original-Cc	Roman Pen <roman.penyaev@profitbricks.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Alexander Viro <viro@zeniv.linux.org.uk>, Dan Williams <dan.j.williams@intel.com>, Gi-Oh Kim <gi-oh.kim@profitbricks.com>, Jens Axboe <axboe@kernel.dk>, Len Brown <len.brown@intel.com>, Ming Lei <tom.leiming@gmail.com>, Pavel Machek <pavel@ucw.cz>, Sagi Grimberg <sagig@mellanox.com>, Tejun Heo <tj@kernel.org>, Vishal Verma <vishal.l.verma@intel.com>, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
X-Original-Date	Mon, 1 Feb 2016 15:51:51 +0100
X-Original-Message-ID	<1454338315-13465-1-git-send-email-roman.penyaev@profitbricks.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1323204

Show key headers only | View raw

Hello.

In this patchset in the first patch I fixed module reference leak inside
blk-cgroup.c.  In other patches I switched to a new put_getdisk() call,
which should be used if the disk was received by get_disk() or get_gendisk()
functions, which internally increase module reference.

The idea is to avoid confusion in the future and to have symmetric calls:

	alloc_disk() -> put_disk() [as it is done in all the block drivers]

and

	get_gendisk() -> put_gendisk() [if you need to find a disk by minor,major]

The second sequence internally increases disk owner module reference on
get and decreases it on put.

Roman Pen (4):
  block: fix module reference leak on put_disk() call for cgroups
    throttle
  block: introduce new call put_gendisk() in genhd.c
  block,fs: switch to a new put_gendisk() call
  hibernate: fix disk and module leak on successfull resume

 block/blk-cgroup.c       |  6 ++---
 block/genhd.c            | 59 +++++++++++++++++++++++++++++++++++++++++++++---
 fs/block_dev.c           | 24 ++++++--------------
 include/linux/genhd.h    |  1 +
 kernel/power/hibernate.c |  5 +++-
 5 files changed, 71 insertions(+), 24 deletions(-)

Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Gi-Oh Kim <gi-oh.kim@profitbricks.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Len Brown <len.brown@intel.com>
Cc: Ming Lei <tom.leiming@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-block@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org

-- 
2.6.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] introduce new put_getdisk() call Roman Pen <roman.penyaev@profitbricks.com> - 2016-02-01 16:00 +0100
  [PATCH 2/4] block: introduce new call put_gendisk() in genhd.c Roman Pen <roman.penyaev@profitbricks.com> - 2016-02-01 16:00 +0100
  Re: [PATCH 0/4] introduce new put_getdisk() call Tejun Heo <tj@kernel.org> - 2016-02-01 18:20 +0100

csiph-web