Re: [RFC 00/26] perf tools: Introduce hists specific format entries

Path	csiph.com!news.freedyn.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC 00/26] perf tools: Introduce hists specific format entries
Date	Tue, 02 Feb 2016 23:30:02 +0100
Message-ID	<qXRCq-1mL-11@gated-at.bofh.it> (permalink)
References	<qSeil-73y-3@gated-at.bofh.it> <qUJBo-rn-7@gated-at.bofh.it> <qUQjw-5hx-29@gated-at.bofh.it> <qUQtc-5oH-17@gated-at.bofh.it> <qXRCq-1mL-5@gated-at.bofh.it>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
X-URL	http://acmel.wordpress.com
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>, David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>
X-Original-Date	Tue, 2 Feb 2016 19:25:21 -0300
X-Original-Message-ID	<20160202222521.GK32488@kernel.org>
X-Original-References	<1453109064-1026-1-git-send-email-jolsa@kernel.org> <20160125071552.GB23869@krava.brq.redhat.com> <20160125142424.GA7794@danjae.kornet> <20160125143743.GA10064@krava.brq.redhat.com> <20160202222247.GJ32488@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1324691

Show key headers only | View raw

Em Tue, Feb 02, 2016 at 07:22:47PM -0300, Arnaldo Carvalho de Melo escreveu:
> Ok, so I rebased it on top of my perf/core branch, adjusting some stuff
> wrt recent patchkits from Namhyung (hist_entry__callchain_fprintf() is
> no more, etc), and renaming that perf_hpp_list->{list,sort_list} to
> ->{fields,sorts} as Namhyung suggested and you agreed, it builds...
> 
> But perf top isn't showing the overhead column... there were some
> changes to perf report in this patchkit to move some initializations...
> will check there...

Double checking...

[acme@jouet linux]$ git bisect bad
cd85325039555bbf37d08d399ae2b1c91c70a565 is the first bad commit
commit cd85325039555bbf37d08d399ae2b1c91c70a565
Author: Jiri Olsa <jolsa@kernel.org>
Date:   Mon Jan 18 10:24:07 2016 +0100

    perf hists: Allocate output sort field
    
    Currently we use static output fields, because we have single global
    list of all sort/output fields.
    
    We will add hists specific sort and output lists in following patches,
    so we need all format entries to be dynamically allocated. Adding
    support to allocate output sort field.
    
    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/1453109064-1026-10-git-send-email-jolsa@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

:040000 040000 f119a49ec0c9954f3117e151719c3c322c1651e4 4bb14abe5005fe29c45eecd9f6fab30fabc0fd99 M	tools
[acme@jouet linux]$

Thread

Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
  Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:30 +0100
  Re: [RFC 00/26] perf tools: Introduce hists specific format entries Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-02-02 23:50 +0100
    Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 09:00 +0100
      Re: [RFC 00/26] perf tools: Introduce hists specific format entries Jiri Olsa <jolsa@redhat.com> - 2016-02-03 12:10 +0100

csiph-web