Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1324246

Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs

From David Vrabel <david.vrabel@citrix.com>
Newsgroups linux.kernel
Subject Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs
Date 2016-02-02 17:30 +0100
Message-ID <qXM01-5FW-5@gated-at.bofh.it> (permalink)
References <qXoTM-4WL-7@gated-at.bofh.it> <qXoTM-4WL-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


This needs some more description in the commit message.

> --- a/arch/x86/xen/smp.c
> +++ b/arch/x86/xen/smp.c
[...]
> +		hctxt->cpu_regs.x86_32.cs_base = 0;
> +		hctxt->cpu_regs.x86_32.cs_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.cs_ar = 0xc9b;
> +		hctxt->cpu_regs.x86_32.ds_base = 0;
> +		hctxt->cpu_regs.x86_32.ds_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.ds_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.es_base = 0;
> +		hctxt->cpu_regs.x86_32.es_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.es_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.ss_base = 0;
> +		hctxt->cpu_regs.x86_32.ss_limit = ~0u;
> +		hctxt->cpu_regs.x86_32.ss_ar = 0xc93;
> +		hctxt->cpu_regs.x86_32.tr_base = 0;
> +		hctxt->cpu_regs.x86_32.tr_limit = 0xff;
> +		hctxt->cpu_regs.x86_32.tr_ar = 0x8b;

Lots of hard-coded values here.  Should this be #defined somewhere?

David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 07/11] xen/hvmlite: Initialize context for secondary VCPUs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-01 16:50 +0100
  Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for  secondary VCPUs David Vrabel <david.vrabel@citrix.com> - 2016-02-02 17:30 +0100
    Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for  secondary VCPUs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-02 18:00 +0100
      Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for  secondary VCPUs David Vrabel <david.vrabel@citrix.com> - 2016-02-04 11:10 +0100
      Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for  secondary VCPUs Doug Goldstein <cardoe@cardoe.com> - 2016-02-04 14:00 +0100
        Re: [Xen-devel] [PATCH v2 07/11] xen/hvmlite: Initialize context for  secondary VCPUs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-04 20:10 +0100

csiph-web