[PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to warning

From	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to warning
Date	2016-02-02 17:30 +0100
Message-ID	<qXM01-5FW-1@gated-at.bofh.it> (permalink)
References	<qXM01-5FW-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Calling isolate_lru_page() is wrong and shouldn't happen, but it not
nessesary fatal: the page just will not be isolated if it's not on LRU.

Let's downgrade the VM_BUG_ON_PAGE() to WARN_RATELIMIT().

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
 mm/vmscan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eb3dd37ccd7c..71b1c29948db 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1443,7 +1443,7 @@ int isolate_lru_page(struct page *page)
 	int ret = -EBUSY;
 
 	VM_BUG_ON_PAGE(!page_count(page), page);
-	VM_BUG_ON_PAGE(PageTail(page), page);
+	WARN_RATELIMIT(PageTail(page), "trying to isolate tail page");
 
 	if (PageLRU(page)) {
 		struct zone *zone = page_zone(page);
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to warning "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-02 17:30 +0100
  Re: [PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to  warning Andrew Morton <akpm@linux-foundation.org> - 2016-02-02 22:00 +0100
    Re: [PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to  warning "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-02 23:10 +0100
  Re: [PATCHv2 2/2] mm: downgrade VM_BUG in isolate_lru_page() to  warning Michal Hocko <mhocko@kernel.org> - 2016-02-03 16:00 +0100

csiph-web