Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322663

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

Show all headers | View raw

Julian Calaby <julian.calaby@gmail.com> writes:
> Hi Bhaktipriya,
>
> On Sat, Jan 30, 2016 at 5:00 AM, Jes Sorensen <Jes.Sorensen@redhat.com> wrote:
>> Bhaktipriya Shridhar <bhaktipriya96@gmail.com> writes:
>> If you insist on pushing this rather unncessary change, please do it
>> properly, and remove the blank line before the return statement as well.
>
> As Jes said, you need to remove the blank lines before the returns
> too. checkpatch should have picked this up, you did run the patch
> through checkpatch before you sent it, right?
>
> Jes,
>
> I know you have strong feelings on coding style, but there are a lot
> of people out there who see deviations from the standard as bugs to be
> fixed, so stuff like this isn't going to stop until it matches the
> coding style document's spec.

Julian,

rtl8723au is pretty dead development wise, so I don't care too much.
checkpatch is broken and has effectively turned into a policing tool for
a few people who wish to apply their narrow view onto everyone else.
I'll continue top reject broken patches to my code pushed out under
those rules.

Maybe it's time to introduce checkpatchconsideredharmful.com

Jes

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8723au: Fixes unnecessary return warning Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-01-29 18:30 +0100
  Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-01-29 19:10 +0100
    Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 00:20 +0100
      Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 02:30 +0100
        Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 04:10 +0100
          Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 04:20 +0100
            Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Bhakti Priya <bhaktipriya96@gmail.com> - 2016-01-30 08:00 +0100
              Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 08:30 +0100
              Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 13:10 +0100
                Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 13:20 +0100
      Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-01-31 15:40 +0100

csiph-web