Groups > linux.kernel > #1321940

Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning

From	Jes Sorensen <Jes.Sorensen@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning
Date	2016-01-29 19:10 +0100
Message-ID	<qWlED-71J-7@gated-at.bofh.it> (permalink)
References	<qWl1V-6td-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Bhaktipriya Shridhar <bhaktipriya96@gmail.com> writes:
> This patch fixes checkpatch.pl warning in rtw_mlme_ext.c file.
> WARNING: void function return statements are not generally useful
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index d28f29a..e8a16b9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -2657,7 +2657,6 @@ static void issue_probersp(struct rtw_adapter *padapter, unsigned char *da)
>
>  	dump_mgntframe23a(padapter, pmgntframe);
>
> -	return;
>  }

If you insist on pushing this rather unncessary change, please do it
properly, and remove the blank line before the return statement as well.

Jes

Thread

[PATCH] staging: rtl8723au: Fixes unnecessary return warning Bhaktipriya Shridhar <bhaktipriya96@gmail.com> - 2016-01-29 18:30 +0100
  Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-01-29 19:10 +0100
    Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 00:20 +0100
      Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 02:30 +0100
        Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 04:10 +0100
          Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 04:20 +0100
            Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Bhakti Priya <bhaktipriya96@gmail.com> - 2016-01-30 08:00 +0100
              Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 08:30 +0100
              Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Julian Calaby <julian.calaby@gmail.com> - 2016-01-30 13:10 +0100
                Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Joe Perches <joe@perches.com> - 2016-01-30 13:20 +0100
      Re: [PATCH] staging: rtl8723au: Fixes unnecessary return warning Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-01-31 15:40 +0100

csiph-web