Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321628

Re: [PATCH 2/7] usb: gadget: pxa25x_udc cleanup

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> This removes the dependency on the mach/hardware.h header file
> from the pxa25x_udc driver after the register definitions were
> already unified in the previous patch.
>
> Following the model of pxa27x_udc (and basically all other drivers
> in the kernel), we define the register numbers as offsets from
> the register base address and use accessor functions to read/write
> them.
>
> For the moment, this still leaves the direct pointer dereference
> in place, instead of using readl/writel, so this patch should
> not be changing the behavior of the driver, other than using
> ioremap() on the platform resource to replace the hardcoded
> virtual address pointers.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>

It's too bad coccinelle cannot make that work more automatic, isn't it ? :)

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] USB changes for rare warnings Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
  [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
    [PATCH 2/7] usb: gadget: pxa25x_udc cleanup Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
      Re: [PATCH 2/7] usb: gadget: pxa25x_udc cleanup Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 11:20 +0100
    Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 10:40 +0100
      Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Arnd Bergmann <arnd@arndb.de> - 2016-01-29 11:10 +0100
        Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 16:30 +0100
    Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch khalasa@piap.pl (Krzysztof Hałasa) - 2016-01-29 17:10 +0100
  [PATCH 7/7] usb: musb/ux500: remove duplicate check for dma_is_compatible Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
  [PATCH 5/7] usb: isp1301-omap: mark power_up as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
    [PATCH 6/7] usb: musb: use %pad format string from dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
      Re: [PATCH 6/7] usb: musb: use %pad format string from dma_addr_t Tony Lindgren <tony@atomide.com> - 2016-01-28 19:00 +0100
  [PATCH 4/7] usb: fsl: drop USB_FSL_MPH_DR_OF Kconfig symbol Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
  Re: [PATCH 0/7] USB changes for rare warnings Felipe Balbi <balbi@kernel.org> - 2016-02-03 19:20 +0100
    Re: [PATCH 0/7] USB changes for rare warnings Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-03 20:20 +0100
      Re: [PATCH 0/7] USB changes for rare warnings Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:00 +0100

csiph-web