Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321610

Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch

Show all headers | View raw

Arnd Bergmann <arnd@arndb.de> writes:

> ixp4xx and pxa25x both use this driver and provide a slightly
> different set of register definitions for it. Aside from that,
> the definition in the ixp4xx-regs.h header conflicts with the
> on in the pxa27x device driver when compile-testing that:
>
> In file included from ../drivers/usb/gadget/udc/pxa27x_udc.c:37:0:
> ../drivers/usb/gadget/udc/pxa27x_udc.h:26:0: warning: "UDCCR" redefined
>  #define UDCCR  0x0000  /* UDC Control Register */
>  ^
> In file included from ../arch/arm/mach-ixp4xx/include/mach/hardware.h:27:0,
>                  from ../arch/arm/mach-ixp4xx/include/mach/io.h:18,
>                  from ../arch/arm/include/asm/io.h:194,
>                  from ../include/linux/io.h:25,
>                  from ../include/linux/irq.h:24,
>                  from ../drivers/usb/gadget/udc/pxa27x_udc.c:23:
> ../arch/arm/mach-ixp4xx/include/mach/ixp4xx-regs.h:415:0: note: this is the location of the previous definition
>  #define UDCCR  IXP4XX_USB_REG(IXP4XX_USB_BASE_VIRT+0x0000)
>
> This addresses both issues by moving all the definitions into the
> pxa25x_udc driver itself. It turns out the only difference between
> them was 'UDCCS_IO_ROF', and that could well be a mistake when it
> was incorrectly copied from pxa25x to ixp4xx.
Hi Arnd,

Is there a reason to have chosen to move into pxa25_udc.c instead of
drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory
with register definitions, hence the question.

Cheers.

--
Robert

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] USB changes for rare warnings Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
  [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
    [PATCH 2/7] usb: gadget: pxa25x_udc cleanup Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:20 +0100
      Re: [PATCH 2/7] usb: gadget: pxa25x_udc cleanup Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 11:20 +0100
    Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 10:40 +0100
      Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Arnd Bergmann <arnd@arndb.de> - 2016-01-29 11:10 +0100
        Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-29 16:30 +0100
    Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch khalasa@piap.pl (Krzysztof Hałasa) - 2016-01-29 17:10 +0100
  [PATCH 7/7] usb: musb/ux500: remove duplicate check for dma_is_compatible Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
  [PATCH 5/7] usb: isp1301-omap: mark power_up as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
    [PATCH 6/7] usb: musb: use %pad format string from dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
      Re: [PATCH 6/7] usb: musb: use %pad format string from dma_addr_t Tony Lindgren <tony@atomide.com> - 2016-01-28 19:00 +0100
  [PATCH 4/7] usb: fsl: drop USB_FSL_MPH_DR_OF Kconfig symbol Arnd Bergmann <arnd@arndb.de> - 2016-01-28 17:30 +0100
  Re: [PATCH 0/7] USB changes for rare warnings Felipe Balbi <balbi@kernel.org> - 2016-02-03 19:20 +0100
    Re: [PATCH 0/7] USB changes for rare warnings Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-03 20:20 +0100
      Re: [PATCH 0/7] USB changes for rare warnings Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:00 +0100

csiph-web