Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1322568
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Chen-Yu Tsai <wens@csie.org> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi |
| Date | Sun, 31 Jan 2016 04:50:01 +0100 |
| Message-ID | <qWRbr-5NN-3@gated-at.bofh.it> (permalink) |
| References | <qWOZY-44I-9@gated-at.bofh.it> <qWOZY-44I-17@gated-at.bofh.it> |
| X-Gm-Message-State | AG10YOQmuxdma4YiENIbt030Uruc3fxmZhPG5UkaO0hfY7f0Ugim2wH6hXMmsoj+ywl/FNfnWQK1UjOGsbcFqA== |
| X-Received | by 10.50.152.41 with SMTP id uv9mr4869386igb.3.1454212005194; Sat, 30 Jan 2016 19:46:45 -0800 (PST) |
| MIME-Version | 1.0 |
| X-Gmail-Original-Message-ID | <CAGb2v65=2VvyiUUHQ_yM_99tEF4pHuvQWWM0q7wTZ0nhVY7+xg@mail.gmail.com> |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 54 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Rob Herring <robh+dt@kernel.org>, Jonathan Corbet <corbet@lwn.net>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Russell King - ARM Linux <linux@arm.linux.org.uk>, Emilio Lopez <emilio@elopez.com.ar>, Jens Kuske <jenskuske@gmail.com>, Hans De Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>, devicetree <devicetree@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org>, linux-sunxi <linux-sunxi@googlegroups.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Reinder de Haan <patchesrdh@mveas.com>, linux-clk <linux-clk@vger.kernel.org> |
| X-Original-Date | Sun, 31 Jan 2016 11:46:25 +0800 |
| X-Original-Message-ID | <CAGb2v65=2VvyiUUHQ_yM_99tEF4pHuvQWWM0q7wTZ0nhVY7+xg@mail.gmail.com> |
| X-Original-References | <1454203266-4450-1-git-send-email-vishnupatekar0510@gmail.com> <1454203266-4450-12-git-send-email-vishnupatekar0510@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1322568 |
Show key headers only | View raw
On Sun, Jan 31, 2016 at 9:21 AM, Vishnu Patekar
<vishnupatekar0510@gmail.com> wrote:
> Now that we have a driver for the R_PIO controller,
> add the corresponding device node to the dtsi.
>
> Signed-off-by: Vishnu Patekar <vishnupatekar0510@gmail.com>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 5ea20ff..11be9e1 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -478,5 +478,26 @@
> compatible = "allwinner,sun6i-a31-clock-reset";
> #reset-cells = <1>;
> };
> +
> + r_pio: pinctrl@01f02c00 {
> + compatible = "allwinner,sun8i-a83t-r-pinctrl";
> + reg = <0x01f02c00 0x400>;
> + interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&apb0_gates 0>;
> + resets = <&apb0_reset 0>;
> + gpio-controller;
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + #address-cells = <1>;
> + #size-cells = <0>;
#address-cells and #size-cells aren't needed. They were incorrectly included
in the first place. They were removed from &pio but not &r_pio.
> + #gpio-cells = <3>;
> +
> + r_rsb_pins: r_rsb {
> + allwinner,pins = "PL0", "PL1";
> + allwinner,function = "s_rsb";
> + allwinner,drive = <SUN4I_PINCTRL_20_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> + };
This setting should be part of the next patch, the RSB node patch.
The rest looks fine.
ChenYu
> + };
> };
> };
> --
> 1.9.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Vishnu Patekar <vishnupatekar0510@gmail.com> - 2016-01-31 02:30 +0100 Re: [PATCH 11/14] ARM: dts: sun8i-a83t: Add R_PIO controller node to the dtsi Chen-Yu Tsai <wens@csie.org> - 2016-01-31 04:50 +0100
csiph-web